FIX GRAMMATICAL ERROR#1
Open
aidenwallis wants to merge 3 commits into
Open
Conversation
it should be `0 seconds` not `0 second` i cannot believe you did this ❗ ❗
pajlada
previously approved these changes
Aug 30, 2021
pajlada
left a comment
pajlada
left a comment
Member
There was a problem hiding this comment.
Very cool! Thanks for your contribution!
|
what if there's a negative value somehow? then it would be -1 seconds? that seems odd to me |
|
You didn't even add a test case to prevent this issue in the future |
Member
|
@aidenwallis Actually I'll retract my approval for now - could you provide a test case in which this case errors out? This should be pretty well-tested already to never print zero values https://github.com/pajbot/utils/blob/master/time_test.go#L59-L77 |
Author
|
eh |
Author
|
hi :) randomly chose to come back |
|
🎃 |
…m so quirky and original xD
|
🐛 |
pajlada
requested changes
Oct 3, 2021
pajlada
left a comment
pajlada
left a comment
Member
There was a problem hiding this comment.
The test does not show a case where the change is needed
Reverting the change to time.go#64 still passes all tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it should be
0 secondsnot0 secondi cannot believe you did this ❗ ❗