Add RHEL dist-git hostname to distgit detector#461
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for identifying RHEL dist-git sources by checking for the 'pkgs.devel.redhat.com' hostname in the dist-git detector. The review feedback highlights a security concern regarding the use of partial string matching for hostname validation, which could be exploited, and recommends using an exact equality check instead. Additionally, the reviewer requested the inclusion of unit tests to verify the new detection logic and prevent regressions.
majamassarini
previously approved these changes
May 8, 2026
Collaborator
Author
|
@majamassarini please have another look. this should do it i think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This literally just adds RHEL dist-git hostname to detect_distgit_source tool to recognize it as dist-git source. The backport agent depends on this to follow the dist-git workflow which it fails to do otherwise. We've found this scenario plays out when RHEL dist-git patch or commit is explicitly added in Jira comments as the source of the patch to backport.