Skip to content

refactor(query engine): introduce Column type - #548

Open
forshev wants to merge 1 commit into
0-record-dont-use-anyfrom
0-column-abstraction
Open

forshev wants to merge 1 commit into
0-record-dont-use-anyfrom
0-column-abstraction

Conversation

@forshev

@forshev forshev commented Sep 30, 2026

Copy link
Copy Markdown
Member

Description

Add Column abstraction that supports getting value of Records's column at Column.idx index


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@forshev
forshev added this pull request to stack #549 September 30, 2026 11:23
@codecov-commenter

codecov-commenter commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.02%. Comparing base (5a04fb0) to head (e02c3a5).

Files with missing lines Patch % Lines
query/column.go 89.58% 5 Missing ⚠️
storeapi/grpc_stream_search.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           0-record-dont-use-any     #548      +/-   ##
=========================================================
+ Coverage                  76.86%   77.02%   +0.16%     
=========================================================
  Files                        248      249       +1     
  Lines                      18890    18910      +20     
=========================================================
+ Hits                       14519    14566      +47     
+ Misses                      4371     4344      -27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@forshev
forshev force-pushed the 0-column-abstraction branch from 63f8a84 to e02c3a5 Compare September 30, 2026 13:50
@eguguchkin eguguchkin added this to the v0.81.0 milestone Oct 5, 2026
@eguguchkin
eguguchkin requested review from dkharms and eguguchkin and removed request for dkharms October 5, 2026 10:28
@forshev
forshev requested a review from dkharms October 5, 2026 10:56
@forshev
forshev removed this pull request from stack #549 October 8, 2026 13:38
@forshev
forshev added this pull request to stack #566 October 8, 2026 13:39
@forshev
forshev removed this pull request from stack #566 October 8, 2026 13:43
@forshev
forshev added this pull request to stack #567 October 8, 2026 13:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants