Repository navigation
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Move login verification into the proxy, now its own crate. Servers trust the key ID a request claims, so a server with no proxy in front needs no login. Co-authored-by: Claude <noreply@anthropic.com>
emilyalbini
approved these changes
Oct 28, 2026
emilyalbini
left a comment
emilyalbini
left a comment
Member
There was a problem hiding this comment.
Thanks for implementing this! Skimmed at the code and I don't see anything obviously wrong with it, I'll take another look at it tomorrow and see if I can think of any reason why this would break. Fairly confident it'll be fine though (we discussed the approach at length in a call earlier today).
plotnick
marked this pull request as ready for review
October 29, 2026 02:01
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the same problem as #107 (races between gossip and requests could lead to multiple touches per login) but without any new machinery. Instead, we move the existing login verification from the server to the proxy (now its own crate), and servers trust the key ID they find on a request. This is allowable since anything on the underlay or bootstrap networks is already implicitly trusted,and will be authenticated with sprockets-backed mTLS in the future.
Draft Omicron integration in oxidecomputer/omicron#11572. Tested on Dublin; one touch suffices to start a session and run jobs across four sleds.