WIP: Flowstats#744
Draft
FelixMcFelix wants to merge 41 commits intomasterfrom
Draft
Conversation
This should make it more clear at each stage which types are being used where. This also reduced struct sizes for each, and in a given `parent`s list we take no more space than an Arc<dyn> would. It may be worth applying the same to `children`.
Now we have the primitives for flow and rule stats. Let's go!
But no action state to exercise it, yet.
Should be better for being able to check predicate matches etc. in downstream VPC impls.
FelixMcFelix
added a commit
that referenced
this pull request
May 7, 2026
This PR cuts down the TCP state entry expiry times for TCP flow entries which are either still within the three-way handshake or are actively being torn down. This does not affect the validity of any LFT entries which are responsible for actually *procesing* matched packets -- these exist on their own 60s expiry cadence. This might have some impact on flow state tracking, but the correct fix there is to get #744 over the line. Should answer for oxidecomputer/customer-support#1125.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of RFD 549.
This PR starts by assigning a full set of packet counters to every rule, LFT, and active flow within OPTE. From here, we track parent relationships to assign credit back to counters and to memorise every ID for every rule hit by a packet in each direction.