Make manifest fields non-optional#658
Open
mkeeter wants to merge 5 commits intohubtools-and-loadingfrom
Open
Conversation
mkeeter
force-pushed
the
mkeeter/remove-options
branch
from
2fc50b9 to
cc5c8ea
Compare
mkeeter
force-pushed
the
hubtools-and-loading
branch
from
fe3feff to
42740e1
Compare
mkeeter
force-pushed
the
mkeeter/remove-options
branch
from
cc5c8ea to
78506ec
Compare
mkeeter
force-pushed
the
hubtools-and-loading
branch
2 times, most recently
from
a80da4f to
f8548f9
Compare
mkeeter
force-pushed
the
mkeeter/remove-options
branch
from
78506ec to
7248bff
Compare
mkeeter
force-pushed
the
mkeeter/remove-options
branch
from
7248bff to
d9a75e8
Compare
mkeeter
force-pushed
the
hubtools-and-loading
branch
from
f8548f9 to
d1f50d6
Compare
labbott
reviewed
May 7, 2026
| .ok_or_else(|| anyhow!("missing image ID"))? | ||
| .1 | ||
| .clone(), | ||
| imageid: hubris.imageid.1.clone(), |
Contributor
There was a problem hiding this comment.
Can this use hubris.image_id() to avoid direct field access? (Same comment a few places)
Contributor
Author
There was a problem hiding this comment.
Good call, I've made the field non-pub so that everyone has to call image_id().
mkeeter
force-pushed
the
mkeeter/remove-options
branch
from
d9a75e8 to
df309fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(staged on top of #657)
Now that #657 makes it impossible to construct a partially-initialized
HubrisArchive, there are many fields which are guaranteed to beSome(..). This PR makes them non-optional, then fixes downstream users.