docs: sync config.sample.php parameters for 10.16 - #138
Merged
Merged
Conversation
The 10.16 page was stale: core added 'web-updater.enabled' to config/config.sample.php in owncloud/core#41385 and the generated page was never regenerated, so the parameter has been undocumented for the 10.16 line ever since. Regenerated with config-to-docs (`php convert.php config:convert-adoc`) from core's 10.16 branch, which is the authoritative source for this page. The diff is purely the one missing section; every other line already matched, and the hand-written header above the "header end" marker is untouched. Found while establishing a regeneration baseline for a different change - the same run confirmed both config_apps_sample_php_parameters.adoc pages and the 11.0 config_sample_php_parameters.adoc are already in sync. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
phil-davis
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the 10.16
config_sample_php_parameters.adocfrom core's10.16branch. Pure sync — one section was missing.What was stale
Core added
web-updater.enabledtoconfig/config.sample.phpin owncloud/core#41385 (commitf1b00f436a, released in v10.16.1) and this page was never regenerated, so the parameter has been undocumented on the 10.16 line ever since.Why this is a regeneration, not an edit
This page is generated by config-to-docs from core's config sample; the sample is authoritative and says so itself. Produced with
ctd.shagainst core10.16, not hand-written.Checked while doing it — the sync is now complete for this file: core's top-level key set and the page's are identical (no key in core missing from the page, none extra), and every key's heading matches core's first comment line. This one parameter really was the only delta. Everything above the
// header endmarker is untouched.Same run confirmed the other three pages need nothing: both
config_apps_sample_php_parameters.adoc(11.0 and 10.16) and 11.0'sconfig_sample_php_parameters.adocregenerate byte-identical to what is committed.web-updater.enableddoes not exist in coremaster, so 11.0 correctly does not get it.The new section lands four lines below this pre-existing text:
That sentence was invalidated by the very commit that added the parameter — #41385 is titled "web updater is now disabled by default + discourage users to use the web updater". So the published page will state, four lines apart, that the web updater is enabled by default and that it is disabled by default.
I have deliberately not papered over this by editing the generated text, because that would break the property this PR exists to establish. The durable fix is in core:
config/config.sample.php— theupgrade.disable-webcomment says "enabled by default" on both10.16andmaster, and is wrong on 10.16.1+.falseand never says thattrueis what enables/updater/, nor carries core's own "not recommended for a long time" guidance from the #41385 changelog.I did not write that core fix myself because I could not establish the truth per branch without guessing:
web-updater.enabledis read nowhere in core's PHP on either branch (it is consumed by the separate updater component), andmaster's sample does not define the key at all while still carrying the "enabled by default" sentence. That wants someone who knows the updater's intent, not an inference from me.Merging this is still an improvement — the parameter goes from undocumented to documented, and the stale sentence is already wrong today with or without this PR. But it should not go out unnoted.
Checks
npm ci && npm run antora && npm testpass; the new section renders on the built 10.16 page.🤖 Generated with Claude Code