Repository navigation
chore(nix): carry pnpm 12.17.0 and transition window to published-effect-4.0 - #2296
schickling-assistant wants to merge 2 commits into
Conversation
agent-identity: agent/effect-utils/effect-utils-manager agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.10.2 agent-runtime: OMP 18.10.2 agent-model: anthropic/claude-opus-5-5 (cherry picked from commit f8755d0)
agent-identity: agent/effect-utils/effect-utils-manager agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.10.2 agent-runtime: OMP 18.10.2 agent-model: anthropic/claude-opus-5-5 (cherry picked from commit 3b19896)
schickling-assistant
added
type:chore
|
Independent review GO at exact head facedb2. The PR contains exactly 2 cherry-picks; their stable patch IDs match f8755d0 (#2218) and 3b19896 (#2242). No Effect 4.1 dependency or lockfile change. At this head, 12.15.0 appears only in the intentional transition declaration in nix/pnpm.nix. All executable hashes and the wrapper hash match main. Generated manifests and install contracts agree with their genie sources. The StyleX fixture store hashes are unchanged, consistent with main. Posted on behalf of @schickling
|
Storybook Previews
Report historyPR 2296 · 2026-11-03 09:36 UTC
|
Pipeline traces24 jobs; 7 successful, 0 failed, 0 cancelled, 17 skipped
All other jobs (19)
Main baseline samples (by job): test-megarepo-store-gc n=0, tested-tree n=7, pr-reviews-resolved n=7, default-ref-policy n=7, pr-buck2-tools n=0, trusted-buck2-remote-cache-proof n=7, test-integration-notion n=7, deploy-storybooks n=7, publish-products n=7, promote-published n=7, consumer-smoke n=7, test-live-deploy-ci-tools n=7, quality n=0, pr-a-inert-buck n=0, test-playwright-tui-react n=0, test[runner=namespace-profile-macos-arm64] n=0, test-integration-restate n=0, cargo n=0, weaver n=0, build-products n=0, test-playwright-utils n=0, test[runner=namespace-profile-linux-x86-64] n=0, source-shape n=0, notify-alignment n=7. 17 job(s) without a start time are omitted from the timeline, not measured as zero. |
|
Published record: CI is green at exact head facedb2 (11 succeeded, 25 skipped, which are merge-queue-only), and the independent GO is above. published-effect-4.0 stays frozen by its ruleset, so this PR is not merged. The exact head is published on the durable branch Posted on behalf of @schickling
|
|
Status: the consumers moved directly to the Effect 4.1 line (the published tip). The branch published-effect-4.0-pnpm-12.17 stays as it is but is currently unused. This PR remains open as the record. Posted on behalf of @schickling
|
Problem and goal
Give downstream consumers staying on Effect 4.0 the pnpm 12.17.0 bump and transition window, without carrying Effect 4.1 changes.
Changes and decisions
Only these commits were carried with
git cherry-pick -x:The transition accepts previous version
12.15.0until2026-11-14T08:17:26Z.Conflict resolutions
None. Both commits applied cleanly onto
d883d18e3a; no manual resolutions or Effect 4.1-only code were needed.Verification
packages.x86_64-linux.pnpmreturned version12.17.0and the expected transition. Focused assertions for version, previous version and exact deadline returnedtrue. feat(nix): declare pnpm 12.15.0 → 12.17.0 transition window #2242 changes onlynix/pnpm.nix, with no test files touched.git diff origin/main -- nix/pnpm.nixwas empty, including all six native executable hashes and the wrapper hash.devenv tasks run genie:runfailed with seven generation errors from missing source-side dependencies (effectand@overeng/otel-contract). No generated output changes were produced.devenv tasks run buck2:editor:bootstrapexceeded its 300-second deadline waiting for shared editor-view storage-budget admission.devenv tasks run genie:check buck2:quick lint:checkexited 1 after 373 seconds. All three requested gates were marked dependency-failed because the same bootstrap prerequisite exceeded its deadline; their check bodies did not execute.devenv shell -- buck2 killanddevenv shell -- buck2 clean.Complexity and concerns
No new complexity: exactly the two-commit carry. Full local verification and regeneration remain blocked on the generator dependency view, so this PR stays draft.
Friction and bottlenecks
Editor-view publication requested 1,677,053,074 bytes while 38,404,535,816 of the 40,000,000,000-byte shared budget was in use. No storage-budget or package-manager guard was bypassed. The observed blocker was dependency-view capacity, not a packageManager mismatch.
Follow-ups
Rerun regeneration and blocked gates when the prerequisite can complete; no unrelated code changes are included.
References
Source PRs: #2218 and #2242.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree