Repository navigation
ci: overlap locked shell-source prefetch with devenv resolution - #2290
Merged
schickling-assistant merged 4 commits intoNov 3, 2026
Merged
schickling-assistant merged 4 commits into
schickling-assistant merged 4 commits into
Conversation
schickling-assistant
added
the
origin:agent
Contributor
Pipeline traces24 jobs; 7 successful, 0 failed, 0 cancelled, 17 skipped
All other jobs (19)
Main baseline samples (by job): test-megarepo-store-gc n=0, pr-buck2-tools n=0, pr-reviews-resolved n=7, tested-tree n=7, default-ref-policy n=7, publish-products n=7, trusted-buck2-remote-cache-proof n=7, promote-published n=7, test-integration-notion n=7, deploy-storybooks n=7, consumer-smoke n=7, quality n=0, test[runner=namespace-profile-linux-x86-64] n=0, weaver n=0, cargo n=0, test-playwright-tui-react n=0, pr-a-inert-buck n=0, test-integration-restate n=0, test-playwright-utils n=0, build-products n=0, test[runner=namespace-profile-macos-arm64] n=0, test-live-deploy-ci-tools n=7, source-shape n=0, notify-alignment n=7. 17 job(s) without a start time are omitted from the timeline, not measured as zero. |
Contributor
Storybook Previews
Report historyPR 2290 · 2026-11-03 10:19 UTC
PR 2290 · 2026-11-03 09:57 UTC
PR 2290 · 2026-11-03 08:11 UTC
|
Collaborator
Author
|
GO at exact head 463badf. Delta 71daf6b..463badf reviewed. Cancellation: brace bodies give the backgrounded PID ownership of the traps; worker cleanup kills and waits for the real fetch child; traps are cleared on normal return (independent review at eb7cfa3). Test permits: single-byte permits read with Posted on behalf of @schickling
|
Collaborator
Author
|
Merge record (effect-utils-manager): head 463badf, CI green (35 checks), independent review GO at this head, no Hypermerge label. Enqueuing. Posted on behalf of @schickling
|
schickling-assistant
deleted the
schickling-assistant/2026-11-03-locked-input-prefetch
branch
November 3, 2026 10:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first shell configuration fetches immutable locked sources after executable resolution, leaving source-download work on the bootstrap critical path.
Goal
Overlap source prefetch with the existing Resolve devenv operation without adding jobs or checks or bypassing native integrity validation.
Decisions
Verification
The gain is to be measured from this PRs pr/quality run against baseline quality job 125740942271: compare the shell-configuration interval and setup+bootstrap. No gain is claimed here. Existing step durations and timestamps provide the measurement.
Complexity
One small shell helper with two fixed workers; no dependency, cache service, retry subsystem, or extra evaluation.
Concerns
Prefetch is useful only if the normal shell backend consumes warmed native fetch state; contention or incompatible fetch caches may erase the overlap benefit. Keep this PR draft until regeneration and measured evidence are available.
Friction & bottlenecks
The source-view dependency graph prevents the required Genie command from starting. Generated outputs will be emitted in the admitted environment, not manually patched.
Follow-ups
None outside the regeneration and measurement gates for this draft.
References
Baseline quality job 125740942271.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree