Repository navigation
fix(ci): admit the tracked capability closure regression - #1879
Merged
schickling-assistant merged 1 commit intoOct 16, 2026
Merged
schickling-assistant merged 1 commit into
schickling-assistant merged 1 commit into
Conversation
schickling-assistant
added
origin:agent
Contributor
Pipeline traces20 jobs; 5 successful, 0 failed, 0 cancelled, 15 skipped
All other jobs (15)
Main baseline samples (by job): pr-reviews-resolved n=0, tested-tree n=0, default-ref-policy n=0, source-shape n=0, test-live-deploy-ci-tools n=0, test-integration-notion n=0, deploy-storybooks n=0, trusted-buck2-remote-cache-proof n=0, quality n=0, test[runner=namespace-profile-macos-arm64] n=0, test-integration-restate n=0, weaver n=0, pr-a-inert-buck n=0, cargo n=0, test[runner=namespace-profile-linux-x86-64] n=0, test-playwright-utils n=0, build-products n=0, test-playwright-tui-react n=0, publish-products n=0, notify-alignment n=0. 15 job(s) without a start time are omitted from the timeline, not measured as zero. |
Collaborator
Author
|
Owner GO at exact head aa2cc18. Independent exact-head GO; focused generated-guard regression accepts capability-closure.test.sh and rejects unrelated.sh/product.tar.gz; exact clean-head check:quick EXIT0. Hosted CI38841066185 and preview38841066077 completed success; final rollup9success22skipped0failed0pending; unresolvedthreads=[]. Broader existing helper suite had one unrelated raster subprocess failure, disclosed in description. Required-context policy unchanged; merge-group inert check still must prove this fix in hosted path. Posted on behalf of @schickling
|
Contributor
Storybook Previews
Report historyPR 1879 · 2026-10-16 03:09 UTC
|
schickling-assistant
deleted the
schickling-assistant/2026-10-16-inert-capability-fixture
branch
October 16, 2026 03:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The authoritative merge-group run for #1795 failed its tracked-payload guard:
The guard admits Nix source and an exact metadata/test allowlist, but the newly tracked capability regression fixture was missing from that allowlist. Failing job.
Goal
Admit this specific source test while continuing to refuse actual product payloads and unregistered shell scripts.
Decisions
Add only
capability-closure.test.shto the existing exact allowlist in the generator and regenerate the workflow. The regression executes the generated guard in a temporary Git repository, accepting that filename and rejectingproduct.tar.gzandunrelated.sh. Required-check policy is unchanged.Verification
Focused regression:
vitest run --root packages/@overeng/genie --config vitest.config.ts src/runtime/github-workflow/ci-workflow-helpers.unit.test.ts -t "tracked inert payload admission"— 1 passed, 93 skipped, exit 0.Independent review: GO, no findings, at
aa2cc1886856ab0cc5b65478593d004d7de2a514.Workflow regeneration completed with
devenv tasks run genie:run(exit 0).Canonical
gate-slot --class gate -- devenv tasks run check:quickpassed at that same head:2026-10-16T02:32:25Z command-exited exit=0,EXIT=0. Receipt records identical start/end head,cleanStart=true,cleanEnd=true,exact=true, outcomecompleted.Complexity
No new production abstraction or dependency.
Concerns
pr-a-inert-buckremains outside required merge contexts; changing its enforcement is intentionally outside this correction.Friction & bottlenecks
The broader workflow-helper suite reported 93 passing tests and one unrelated subprocess failure in its raster-failure fixture (
result.statuswas null). The focused payload-policy regression passed.Follow-ups
None added by this narrowly scoped fix.
References
Refs #1795.