feat: update prometheus to 0.311.3 - #25
Draft
tdakkota wants to merge 26 commits into
Draft
Conversation
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the golang group with 1 update: [golang.org/x/tools](https://github.com/golang/tools). Updates `golang.org/x/tools` from 0.39.0 to 0.42.0 - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.39.0...v0.42.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-version: 0.42.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.5.0 to 6.4.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@d35c59a...4a36011) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.4.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…cache-5 build(deps): bump actions/cache from 4 to 5
…setup-go-6.4.0 build(deps): bump actions/setup-go from 5.5.0 to 6.4.0
…7052e build(deps): bump golang.org/x/tools from 0.39.0 to 0.42.0 in the golang group
Bumps the golang group with 1 update: [golang.org/x/tools](https://github.com/golang/tools). Updates `golang.org/x/tools` from 0.42.0 to 0.44.0 - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.42.0...v0.44.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-version: 0.44.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4 to 5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@v4...v5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…dependency-review-action-5 build(deps): bump actions/dependency-review-action from 4 to 5
…188e2 build(deps): bump golang.org/x/tools from 0.42.0 to 0.44.0 in the golang group
Signed-off-by: Mustafain Ali Khan <mustalik@amazon.com>
If we have multiple matchres for the same engine, they would not trigger
the passthrough, consider
a{region="west"} / b{region="west"}
This would lead to multiple matching regions and not trigger passthrough
properly.
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
We should only have remote executions that maintain the partition. Add a fuzzing test to check that invariant. Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
…#699) Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
Fix isBinaryExpressionWithDistributableMatching to check all partition labels instead of only the first one. The loop had a return statement inside the body, causing it to exit on the first iteration. With multiple partition labels (e.g. region + datacenter), only one arbitrary label was checked, potentially allowing incorrect distribution. Move LIMIT_RATIO from the mathematically distributive aggregation list to the non-distributive group. Applying limit_ratio remotely and then locally results in double-application (e.g. 0.5 * 0.5 = 0.25 ratio instead of the intended 0.5). It can still be pushed as-is when partition labels are preserved. Add label_join handling alongside label_replace in both isDistributive and preservesPartitionLabels. Previously, label_join targeting a partition label (e.g. label_join(metric, "region", ...)) was not detected, allowing incorrect distribution or partition label loss. Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
Signed-off-by: Michael Hoffmann <mhoffmann@cloudflare.com>
* max samples limit Signed-off-by: Paurush Garg <paurushg@amazon.com> * Update max_samples tracking to selector operators Signed-off-by: Paurush Garg <paurushg@amazon.com> * Update to check maxSamples more frequently Signed-off-by: Paurush Garg <paurushg@amazon.com> * Updating maxSample check interval steps Signed-off-by: Paurush Garg <paurushg@amazon.com> * Add unit tests for max_samples Signed-off-by: Paurush Garg <paurushg@amazon.com> * Apply linter formatting Signed-off-by: Paurush Garg <paurushg@amazon.com> * Update SubQuery Sample tracker to inner loop and remove update matrix_selector maxSamples logic Signed-off-by: Paurush Garg <paurushg@amazon.com> * Remove Checking when delta is negative in matrix_selector Signed-off-by: Paurush Garg <paurushg@amazon.com> * convert SampleTracker to interface with nop implementation Signed-off-by: Paurush Garg <paurushg@amazon.com> --------- Signed-off-by: Paurush Garg <paurushg@amazon.com>
* engine: add deterministic operator IDs, pass through context Create deterministic operator IDs that only depend on the position of the operator in the tree. This will allow merging multiple trees if, for example, query-frontend shards the same query into multiple ones. This also allows attaching arbitrary metadata on the Thanos side without the PromQL engine knowing anything about it. I haven't checked 100% all cases whether all IDs are REALLY deterministic but that will come up during implementation on the other side. I played around a bit and this fully enables enriching Explain functionality with fan-out data. V2 of thanos-io/promql-engine#490. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * execution: fix tests The context used during construction time does not have the same deadline & cancelation signals as the one called in a loop in Exec(). So, enrich the context using sync.Once because these functions are always called with the same context. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> --------- Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
tdakkota
force-pushed
the
gemini/update-prometheus
branch
from
May 12, 2026 06:40
8c5e674 to
d31a092
Compare
Iteration 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.