Repository navigation
Conversation
Extend the --details help text of osism baremetal list: it now says that the Last Error column is cut to 80 characters and names the openstack commands that show the full text. Ironic's last_error is often longer than 80 characters, and the part that explains the failure tends to come late in the message, past the cut. The table keeps the cut so it stays readable on a terminal, so operators need to know where to find the rest: - openstack baremetal node show NODE -c last_error shows the node's current error in full. - openstack baremetal node history list NODE --long shows earlier errors in full as well. Without --long, Ironic's API shortens each history event to 255 characters. Ironic clears last_error once a later operation succeeds, while the history keeps older errors. The width in the help text is taken from LIST_LAST_ERROR_WIDTH, so the two cannot drift apart. A --format json option that would print the full text was considered and left out. Apart from the NetBox device role, openstack baremetal node list --fields ... -f json already returns the same raw fields. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osism baremetal list --detailscuts the Last Error column to 80 characters, but the part of an Ironic error that explains the failure often comes after that. This PR leaves the table as it is and makes the--detailshelp text say where the full text is:openstack baremetal node show NODE -c last_error: the node's current error, in full.openstack baremetal node history list NODE --long: earlier errors, also in full. Without--long, Ironic's API shortens each history event to 255 characters. Ironic clearslast_erroronce a later operation succeeds; the history keeps older errors.The 80 in the help text is taken from
LIST_LAST_ERROR_WIDTH, so the help stays correct if the width changes.We considered a
--format jsonoption that would print the full text and left it out. Apart from the NetBox device role,openstack baremetal node list --fields … -f jsonalready returns the same raw fields.Only the help text changes, so there are no test changes.
🤖 Generated with Claude Code