fix(profile): fail unavailable source observations explicitly - #25
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe profile refresh now treats unavailable or invalid source content as a failure, preserves the profile, documents exit codes, adds outcome tests, and runs those tests in minimal CI. ChangesProfile refresh behavior
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Profile refresh now preserves the existing profile when its source is unavailable or invalid, while retaining explicit outcomes for drift, parity, and successful updates. The implemented behavior and CI coverage indicate no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Verification at Hosted CI has not executed: validate job 102468409578 reports failure with no steps. The Copilot review receipt explicitly reports an account billing lock. This is an infrastructure/startup blocker, not a source-test failure or a hosted pass. The default source remains unavailable (observed HTTP 404 / exit 2); no profile publication occurred. The paired source-owner correction is organvm/organvm-corpvs-testamentvm#554. |
The profile refresh currently returns success when its source cannot be fetched or is invalid. That makes HTTP failures look like confirmed projection parity and hides a stale organization profile.
This repair distinguishes observed parity/successful update (exit 0), observed drift in check mode (exit 1), and unavailable or invalid source (exit 2). Failure preserves the current profile and stops the existing workflow before its commit step. The existing CI job now runs seven regressions covering HTTP/transport/decode failure, invalid content, drift, parity, successful update, and preservation of the independently owned portfolio-hub block.
Validation: seven stdlib tests pass; git diff --check passes. A live --check returned exit 2 with HTTP 404 and left the profile unchanged. This is an unavailable source observation, not current projection parity. Source access must be repaired through an authorized publication/access path; no credential or public identity copy is changed by this PR.
Refs 4444J99/limen#2214. This technical prerequisite does not close PSP-P07-W02 or approve public identity publication. Rollback: revert this scoped commit; profile content is untouched.
Summary by CodeRabbit
Bug Fixes
Tests