Repository navigation
fix: the Planner landing page lives at exactly /planner - #280
Merged
Merged
Conversation
The canonical address and every link to the Planner page use /planner with no trailing slash. /planner/ redirects there (nginx and the Cloudflare Workers _redirects file), so there is one address. The link check accepts a path without a trailing slash that names a folder with an index page.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Products Research decided that the Planner landing page lives at exactly https://orbyn.dev/planner.
https://orbyn.dev/planneralready returned the page on the live site. The canonical address and the links to it still used/planner/, and that form served the same page, so there were two addresses./planner./planner/redirects to/plannerwith a 301: alocation =rule innginx.conf, andsite/public/_redirectsfor Cloudflare Workers. The Dockerfile removes_redirectsfrom the nginx image, as it does_headers.scripts/serve-site.mjs) follows the same rule.Not changed: the other pages keep their trailing-slash addresses (
/apps/,/notes/and so on). The designs show slashless addresses for every page; I limited this change to Planner as decided, and can extend it if wanted.CalDAV (dav.orbyn.dev, Planned) is not on the site today and no design shows it, so I asked the designer where it should appear. Nothing here builds it.
Checks
node scripts/build-site.mjs --check/planner./plannerreturns 200 and/planner/redirects to/planner._redirectsfile. Docker isn't running here and there is no local nginx; CI builds the image but does not run it. After the next deploy, check thatcurl -sI https://orbyn.dev/planner/answers301withlocation: /planner.Risk and undo
Only the Planner address changes. If the nginx rule were wrong,
/planner/could misbehave;/plannerwould not. Revert the PR to undo.AI usage
Claude Code with Claude Sonnet 5.5 (
claude-sonnet-5-5). No external sources.