Repository navigation
feat(crew): route by data class from the committed crew.json - #534
Open
kinqsradio wants to merge 2 commits into
Open
kinqsradio wants to merge 2 commits into
kinqsradio wants to merge 2 commits into
Conversation
github-actions
Bot
added
dependencies
UI previewFrames built: 0 drawn from the dev-only mock app (fake data, no account), commit Not screens the preview knows: Every image, as one download: this workflow run. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let ok = |rules: Vec<Value>| parse_file(&file(rules)); | ||
| let bad = |text: String, words: &str| { | ||
| let why = parse_file(&text).expect_err(&text); | ||
| assert!(why.contains(words), "{why:?} should mention {words:?}"); |
| let why = parse_file(&file(vec![secret])).unwrap_err(); | ||
| assert!( | ||
| why.contains("secret") || why.contains("key") || why.contains("token"), | ||
| "{why}" |
| why.contains("secret") || why.contains("key") || why.contains("token"), | ||
| "{why}" | ||
| ); | ||
| assert!(!why.contains("aaaaaaaa"), "{why}"); |
…w after the route
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classesin.orbyn/crew.json, read through hardened git at the checkout's HEAD when the task starts (pinned for the task, not read from the checkout's files), strict, and failing closed when invalidpath_class; an explicit engine tag on a blocked engine is refused, never swappedroute_classledger row (classes, blocked engines, chosen engine, commit and blob); a refusal keeps the fullrejectedlistGET /api/crew/classes,/api/crew/classes/test,/api/crew/route/{task}Known limits: the rules are read at the checkout's HEAD; an agent that can run git can move HEAD to a commit without the file (reading a ref an agent cannot move, such as the default branch, is a later change). A thread with no commit is now refused. Review briefs have no files, so they count as every class.
Refs slice 4i (production-linked target rules), routing by data class (PR A of three: guard is PR B, screens are PR C).
Parity rows
none
Frames built
Frames built: none (routes only; route-class-* and classes-* frames are built in PR C)
Testing
--workspace --all-targets -D warnings,crew::(294),store::, orbyn-contracts, orbynd crew routes,check_rust_arch.pyCo-authors
none
AI usage
Checklist
web/src/generatedwith any contract change;docs/architecture.mdwith any rule change