Repository navigation
fix(core): keep the lead MCP endpoint out of process argv and env - #529
Merged
Merged
Conversation
The ACP stdio bridge got the run's endpoint, token included, in its environment, which another process of the same user can read. It now gets the path of an owner-only file in the run's folder, removed with the run.
A process started ahead of the next turn wrote its mcp.json, token included, into a shared temporary folder. It now goes in a warm-<id> folder under the runs folder. open_raw takes an explicit run folder. SPEC section 11 updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acp-mcp-endpoint) in the run folder, named byORBYN_ACP_MCP_ENDPOINT_FILE; the endpoint is no longer in any argv or environment.mcp.json(0600, run folder), Codex gets its endpoint over stdin; neither exposes the token. Docs updated; the "known limit" sentence is removed, the one about command lines and environment stays.Closes #528
Parity rows
none
Frames built
Frames built: none
Testing
mcp.jsonnow lives in<data>/runs/warm-<id>(0700, removed when Orbyn drops the process or at the run's end, swept at start-up) instead of the temp folder;open_rawtakes an explicit run folder; SPEC section 11 updated. The real-service test asserts the warm token file is underruns/warm-*/and that no neworbyn-probe-*folder holds/mcp/.orbynd+ fake ACP agent: the bridge's live argv and environment (read bysysctlKERN_PROCARGS2 on macOS,/procon Linux) hold the file path and no token; the bridge lists tools andacp-mcp-callworks from the file; the file is mode 0600; the run folder is gone after the run.launchdoes rather than starting Claude.Co-authors
none
AI usage
Checklist
docs/architecture.mdwith any rule change