Repository navigation
fix(device-client): keep the keys and session when the save fails - #131
Merged
Merged
Conversation
After the emailed code is spent, a failed key-store save keeps the new device's keys and the session in PendingSignUp. retry_save (or another verify_sign_up) saves them with no new code. The fallback when the sign-up is dropped first, the delete-unused link, is now documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PendingSignUp(memory only, wiped on drop).retry_save(&mut pending)saves them with no server call;verify_sign_upagain does the same whatever code is passed.StoreNotEmpty; nothing to save isInvalidInput.PendingSignUpis dropped first: the delete-unused link (docs/device-client.md).Testing
Co-authors
none
AI usage
Checklist
docs/architecture.mdwith any rule change; generated wire types with any contract change