Repository navigation
feat(device-client): approve, deny and remove devices - #130
Merged
Merged
Conversation
Adds the device-client calls for the two-way approval (start, state, confirm and deny on the approver; pending, join, digits, finish and deny on the new device) and remove_device. Every signature and check stays in the engine; the client moves messages in order and maps the new server errors to typed ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_approval,approval_state,confirm_approval,deny_approval(approver);pending_approval,join_approval,device_digits,finish_approval,deny_joined(new device);remove_device.ClientConfig.appjoins with the description it signed in with (join_approval_labelled).ApprovalExpired,ApprovalNotReady,ApprovalMismatch,LastTrustedDevice;wrong_codemaps toInvalidCode.Testing
Co-authors
none
AI usage
Checklist
docs/architecture.mdwith any rule change; generated wire types with any contract change