Repository navigation
feat(auth): bind the device description into the approval pairing - #129
Merged
Merged
Conversation
A device that named its app has its name, platform and app added to the approval commitment and the six digits, and its approver signs the v3 approval message over the same description. The server, the new device and every verifier of the approval chain accept only v3 for such a device, so a changed or dropped label never falls back to an older message. Closes #73.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applabel has its name, platform and app added to the approval commitment and the SAS digits (context…/described), and its approver signsorbyn/device-approval/v3(v2 bytes + description).finish_approval) and every chain verifier accept only v3 for a labelled device: a changed or dropped label cannot fall back to v2/v1; no endorsement fails.Engine::join_approval_labelledfor the new device;start_approvaltakes the description from the device list. Unlabelled devices (Planner) approve exactly as before.remove_deviceAPI follows.Closes #73
Testing
Co-authors
none
AI usage
Checklist
docs/architecture.mdwith any rule change; generated wire types with any contract change