feat: persist competitor media url for tier-2 save fallback#18
Merged
Conversation
Adds nullable CompetitorCreative.mediaUrl (+ migration): ingest now stores each row's captured media URL, and POST /api/competitors/media falls back to it when no sourceUrl is passed — so Tier-2 'Save video' no longer always needs a hand-pasted direct link (P2-8). A caller-supplied sourceUrl still overrides (URLs may be signed/expiring). SSRF + 50MB cap + audit unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2-8. Nullable
CompetitorCreative.mediaUrl(+ migration): ingest stores each row's captured media URL, andPOST /api/competitors/mediafalls back to it when nosourceUrlis given — Tier-2 'Save video' no longer always needs a hand-pasted direct link. CallersourceUrlstill overrides (links may be signed/expiring). SSRF + 50MB cap + audit unchanged.🤖 Generated with Claude Code