bump lix#89
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14dbe3c51f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| out = out.replace( | ||
| /\blix_working_changes\s+as\s+([A-Za-z_][A-Za-z0-9_]*)/g, | ||
| `${emptyWorkingChangesSubquery()} as $1`, | ||
| ); | ||
| out = out.replace(/\blix_working_changes\b/g, emptyWorkingChangesSubquery()); |
There was a problem hiding this comment.
When the desktop app queries lix_working_changes (for example selectWorkingDiffCount and selectWorkingDiffFiles), this rewrite substitutes a WHERE false subquery, so every pending-change query returns zero rows after edits. In that context the checkpoint panel and diff badges never show uncheckpointed file changes, even though the underlying file state changed.
Useful? React with 👍 / 👎.
| async createCheckpoint() { | ||
| const result = await nativeLix.execute( | ||
| "SELECT lix_active_branch_commit_id() AS id", | ||
| ); | ||
| const id = String(result.rows[0]?.get("id") ?? crypto.randomUUID()); | ||
| return { id, changeSetId: id }; |
There was a problem hiding this comment.
Clicking “Create checkpoint” now only returns the current active branch commit id and does not create or label a checkpoint. The history/checkpoint queries look for commits labeled with lix_label.name = 'checkpoint', so checkpoints created through the Electron runtime will not appear in history and will not clear/report working changes as expected.
Useful? React with 👍 / 👎.
| return { | ||
| sequence: event.sequence, | ||
| stateCommitSequence: event.stateCommitSequence, | ||
| rows: event.rows.rows, | ||
| columns: event.rows.columns, |
There was a problem hiding this comment.
This unwraps the IPC query result so desktop observe events now expose event.rows as an array plus top-level columns, but TipTapEditor still reads event.rows.rows[0] when applying external file updates. In the desktop runtime that makes firstRow null for every observed update, so edits made through another view/window are never reflected in an already-open editor.
Useful? React with 👍 / 👎.
1 participant
No description provided.