chore(deps): update rust crate icu_casemap to v2.3.0 - #347
Merged
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ICU4X 2.3 deprecates six non-UCD property markers and the canonical combining class numeric accessor. ANTLR's Java UnicodeData surface still exposes those properties, while the manifest remains compatible with ICU4X 2.2. Isolate the required compatibility uses behind narrow deprecation allowances so the dependency update passes strict clippy without dropping Unicode-property parity or raising the minimum dependency version.
Copy/Paste DetectionNo duplications found in 1 changed non-generated Rust file(s) (threshold: 100 tokens). |
📊 Source Code Metrics (this PR vs
|
| File | Cyclomatic | Cognitive | Functions | LLOC | MI |
|---|---|---|---|---|---|
| crates/antlr-rust-codegen/src/grammar/unicode.rs | 237 (main: 234) 🔴 | 92 (main: 91) 🔴 | 63 (main: 61) 🔴 | 353 (main: 350) 🔴 | 0 ⚪ |
Generated by mehen v1.8.1 — the code quality watcher.
Contributor
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icu_casemapand its ICU4X dependency graph from 2.2.0 to 2.3.0Why
ICU4X 2.3 deprecated six non-UCD binary-property marker types and the
canonical combining class numeric accessor. ANTLR's Java Unicode data surface
still exposes those properties, and the Rust generator verifies parity against
that surface, so removing them would be a behavior regression.
Verification
cargo clippy --locked --workspace --all-targets --all-features -- -D warningscargo test --locked --workspace --all-featurescargo test --locked -p antlr-rust-codegen every_unicode_property_and_alias_matches_java -- --nocapture