Skip to content

Fix release tag authentication #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigboateng merged 1 commit into from
Aug 7, 2026
Merged

Fix release tag authentication #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,9 @@ jobs:
echo "Tag $TAG already exists" >&2
exit 1
fi
git tag "$TAG" "$GITHUB_SHA"
git push origin "refs/tags/$TAG"
gh api --method POST "repos/$GITHUB_REPOSITORY/git/refs" \
-f ref="refs/tags/$TAG" \
-f sha="$GITHUB_SHA"
gh release create "$TAG" \
--repo "$GITHUB_REPOSITORY" \
--title "$TAG" \
Expand Down
2 changes: 2 additions & 0 deletions scripts/check-release-control.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ export async function checkReleaseControl(root = resolve(import.meta.dirname, ".
expect(release.permissions?.contents === "read", "release planning must be read-only");
expect(release.jobs?.release?.permissions?.contents === "write", "tag creation alone needs contents:write");
expect(release.jobs?.release?.environment === "release-control", "release authorization must use the protected release-control environment");
expect(raw["release.yml"].includes('repos/$GITHUB_REPOSITORY/git/refs'), "release controller must create tags with its scoped GitHub token");
expect(!raw["release.yml"].includes('git push origin "refs/tags/$TAG"'), "release controller must not push tags without explicit authentication");
expect(raw["release.yml"].includes("--draft"), "release controller must create a draft release");
expect(!raw["release.yml"].includes("--draft=false"), "release controller must not finalize its own release");

Expand Down