Skip to content

Fix npm canary version assembly #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigboateng merged 1 commit into from
Aug 7, 2026
Merged

Fix npm canary version assembly #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packaging/assemble.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,17 @@ import process from "node:process";
import { binaryName, npmPackage, rustPackage, targets } from "./targets.mjs";

const root = resolve(import.meta.dirname, "..");
const stableVersion = /^\d+\.\d+\.\d+$/;
const canaryVersion = /^0\.0\.0-canary\.\d{14}\.[0-9a-f]{12}$/;

export function isPackageVersion(value) {
return stableVersion.test(value) || canaryVersion.test(value);
}

function parseArgs(argv) {
const values = {};
for (let index = 0; index < argv.length; index += 2) values[argv[index]?.replace(/^--/, "")] = argv[index + 1];
if (!/^\d+\.\d+\.\d+$/.test(values.version ?? "")) throw new Error("--version must be semver without a leading v");
if (!isPackageVersion(values.version ?? "")) throw new Error("--version must be stable semver or a Yield canary version");
if (!values.binaries || !values.output) throw new Error("--binaries and --output are required");
return { version: values.version, binaries: resolve(values.binaries), output: resolve(values.output) };
}
Expand Down
10 changes: 9 additions & 1 deletion packaging/assemble.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,17 @@ import assert from "node:assert/strict";
import { mkdtemp, mkdir, readFile, rm, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { tmpdir } from "node:os";
import { assemble } from "./assemble.mjs";
import { assemble, isPackageVersion } from "./assemble.mjs";
import { binaryName, npmPackage, targets } from "./targets.mjs";

test("accepts stable and exact Yield canary versions", () => {
assert.equal(isPackageVersion("1.2.3"), true);
assert.equal(isPackageVersion("0.0.0-canary.20260807104031.b081bae38282"), true);
assert.equal(isPackageVersion("1.2.3-beta.1"), false);
assert.equal(isPackageVersion("0.0.0-canary.latest.b081bae38282"), false);
assert.equal(isPackageVersion("v1.2.3"), false);
});

test("assembles one public npm package and six matching runtimes", async (t) => {
const root = await mkdtemp(join(tmpdir(), "yield-assemble-"));
t.after(() => rm(root, { recursive: true, force: true }));
Expand Down