Reject work dependencies whose producer cannot serve the consumer objective - #234
Merged
Conversation
…ective Compilation proves only predicate and priority ordering for work-output dependencies, so a program could attach producer work to plan.abandon (safely-abandoned only) and dependent consumer work to publication.observe (published-pr). A published-pr run then selects the consumer, redirects to the missing producer output, targeted resolution refuses plan.abandon for that objective, and the unchanged state re-selects the consumer: a permanent zero-progress path. RuntimeManifest now requires, after trusted TargetIDs are projected, that every work-output producer's target set covers its consumer's target set, over both transition-parameter and foreground-work-input edges.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Codex automated review
Verdict: patch is correct
Confidence: 0.93
The new manifest validation consistently covers work-output dependencies in transition parameters and foreground-work inputs after trusted target projection. No actionable regression was established. Model-level verification is not required before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizeWorkInputProducers(and the transition-parameter work-output path) prove only predicate and priority ordering, so a valid program can attach producer work toplan.abandon(supported only forsafely-abandoned) and dependent consumer work topublication.observe(supported for published-pr targets). Compilation and runtime-manifest construction accepted both.publication.observeis selected, the missing work output redirects toplan.abandon, targeted resolution refusesplan.abandonfor that objective, and the unchanged state selectspublication.observeagain — a permanent zero-progress path.Definition.RuntimeManifestnow requires, after trusted TargetIDs are projected (including theplan.abandonselection-class upgrade), that every work-output producer's projected target set covers its consumer's target set. Both dependency edge kinds are checked: transition parameter bindings and foreground-work inputs. Per-edge coverage extends transitively across chains.Test plan
TestWorkOutputProducerMustCoverConsumerTargets: extends the abandonment-entry fixture with the uncovered dependency; the document compiles (demonstrating the gap) andRuntimeManifestrejects it.plan.validate, which supports every trusted class the consumer supports) stays admissible.go test ./flow/softwaredelivery/...passes; full module suite matches origin/main (the only failures are pre-existing TypeScript-frontend conformance tests that fail identically on a clean checkout).