perf(rv64): split base_alu into add_sub and xor_or_and chips#2883
Open
GunaDD wants to merge 2 commits into
Open
perf(rv64): split base_alu into add_sub and xor_or_and chips#2883GunaDD wants to merge 2 commits into
GunaDD wants to merge 2 commits into
Conversation
Re-do of PR #2777 (base_alu part only) on top of the u16 memory-bus limbs change. The 64-bit BaseAlu chip is split into: - add_sub: ADD/SUB with carry constraints, send_xor(a,a,0) result range checks, and the paired send_range(b,c) read-byte bounds required now that the memory bus only checks packed u16 values - xor_or_and: XOR/OR/AND via the bitwise lookup, which already bounds the read bytes The BaseAlu core (cols/AIR/executor/filler) is kept since the bigint INT256 extension still uses it; its rv64-specific execution/cuda/tests move to the new chips. base_alu_w is left untouched for now. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Note: cells_used metrics omitted because CUDA tracegen does not expose unpadded trace heights. Commit: 068dbdc |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-do of PR #2777 (base_alu part only), now on top of the u16 memory-bus limbs change. Summary of the changes:
Closes INT-8102