fix: reject dead AOT PC slots#2856
Open
Kuhai9801 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2852.
Summary
AOT dispatch now emits fallback handlers for padded PC slots before
pc_baseand for explicitNoneprogram slots. This keeps pure and metered AOT behavior aligned with the interpreter for unreachable PCs instead of dispatching through a dead table slot.Testing
OPENVM_FAST_TEST=1 OPENVM_SKIP_DEBUG=1 cargo test -p openvm-rv32im-circuit --features aot test_aot_dispatch_rejects_dead_pc_slotscargo +nightly fmt --all -- --checkcargo clippy -p openvm-circuit -p openvm-rv32im-circuit --features aot --all-targets -- -D warnings