Added a possibility to configure max epochs per block.#2770
Conversation
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: established 2012 account with write permission, substantial prior subtensor PR history, no committer mismatch, no trusted Gittensor allowlist match; branch feat/configure-max-epochs-per-block -> devnet-ready. Static-only review found a narrow root-gated runtime/admin change: FindingsNo findings. ConclusionNo malicious code or security vulnerability found in the reviewed diff. The new setter is 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor UNKNOWN: no trusted allowlist match; author has write permission and substantial prior subtensor history, so calibrated as an established contributor. Spec version is bumped from The added tests cover non-root rejection, zero-value rejection, storage/event update, and the configured cap's effect on epoch deferrals. I did not run targeted cargo tests because I did not find a defect requiring runtime confirmation. No overlapping open PR appears to implement the same configurable max-epochs-per-block feature; the overlaps are incidental shared runtime/mock files or unrelated deployment/feature PRs. FindingsNo findings. Prior-comment reconciliation
ConclusionThe PR implements the requested configurable epoch cap in a small, bounded, root-only path with the required runtime version bump and focused tests. I found no blocking domain issues. 📜 Previous run (superseded)
|
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👎 |
- updated type - added more tests
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Description
Added a possibility to configure max epochs per block via root call.
Related to #2638.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.