-
Notifications
You must be signed in to change notification settings - Fork 317
try to fix dev timeout #2765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
open-junius
wants to merge
6
commits into
devnet-ready
Choose a base branch
from
fix-dev-timeout
base: devnet-ready
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−59
Open
try to fix dev timeout #2765
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d6977eb
try to fix dev timeout
open-junius 7302ada
revert parameter updates
open-junius 2791588
remove manual seal
open-junius b8886cc
complete revert
open-junius f7a7bc3
update lock file
open-junius aa0df99
revert lock file
open-junius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MEDIUM] Do not parallelize the shared dev chain tests
The
devMoonwall suite is not isolated per test file: the existing files undersuites/devreuse shared keyring accounts such as Alice/Bob, mutate global chain state, register subnets, sudo-set parameters, and manually create blocks against the configured dev foundation. EnablingmultiThreadslets those files run concurrently against that same environment, so nonce reads, block creation, subnet IDs, balances, and pallet state can race each other. That makes the timeout fix non-deterministic and can turn passing tests into flakes.Keep this disabled unless the suite is first split so each worker gets an isolated node/state snapshot or the tests are made concurrency-safe.