Skip to content

Adds min_childkey_take to hyperparams v3 #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnReedV merged 2 commits into from
Jun 17, 2026
+13 −0
Merged

Adds min_childkey_take to hyperparams v3 #2761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
499b515
commit Cargo.lock
thewhaleking Jun 12, 2026
d6a3e51
Merge branch 'devnet-ready' into feat/thewhaleking/add-min_childkey_t…
thewhaleking Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pallets/subtensor/src/rpc_info/subnet_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,11 @@ impl<T: Config> Pallet<T> {
HyperparamValue::Bool(Self::get_owner_cut_auto_lock_enabled(netuid)),
)
.into(),
(
"min_childkey_take",
HyperparamValue::U16(Self::get_effective_min_childkey_take(netuid).into()),
)
.into(),
])
}
}
8 changes: 8 additions & 0 deletions pallets/subtensor/src/tests/subnet_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ const EXPECTED_V3_NAMES: &[&[u8]] = &[
b"user_liquidity_enabled",
b"owner_cut_enabled",
b"owner_cut_auto_lock_enabled",
b"min_childkey_take",
];

fn find<'a>(params: &'a [HyperparamEntry], name: &[u8]) -> &'a HyperparamValue {
Expand Down Expand Up @@ -121,6 +122,8 @@ fn test_get_subnet_hyperparams_v3_values_reflect_storage() {
SubtensorModule::set_bonds_reset(netuid, true);
SubtensorModule::set_owner_cut_enabled_flag(netuid, true);
SubtensorModule::set_owner_cut_auto_lock_enabled(netuid, true);
SubtensorModule::set_min_childkey_take(31);
SubtensorModule::set_min_childkey_take_for_subnet(netuid, 32);

let result = SubtensorModule::get_subnet_hyperparams_v3(netuid).unwrap();
let p = &result;
Expand Down Expand Up @@ -180,6 +183,11 @@ fn test_get_subnet_hyperparams_v3_values_reflect_storage() {
&HyperparamValue::U16(Compact(30))
);
assert_eq!(find(p, b"yuma_version"), &HyperparamValue::U16(Compact(3)));
// Effective min childkey take = max(global, per-subnet).
assert_eq!(
find(p, b"min_childkey_take"),
&HyperparamValue::U16(Compact(32))
);

// U64 variants
assert_eq!(
Expand Down
Loading