Repository navigation
Conversation
Lets xtest gate the DSPX-4886 partial-decrypt tests via otdfctl --version --json, using the feature names from DSPX-5117. Part of DSPX-4886. Signed-off-by: sujan kota <sujankota@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 similar comment
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
|
Proposed Changes
Part of DSPX-4886. Adds two entries to
sdk.SupportedFeatures(), surfaced byotdfctl --version --jsonassupported_features, so xtest's gocli.sh supportscan gate the DSPX-5117 partial-decrypt tests:partial_decrypt—otdfctl decrypt --offset/--length(feat(otdfctl): support decrypt --offset/--length and HTTP(S) URLs #4229)http_range_source— anhttp(s)://decrypt input loaded with HTTP range requests (feat(sdk): load TDFs from HTTP(S) URLs using range requests #4221, feat(otdfctl): support decrypt --offset/--length and HTTP(S) URLs #4229)Names are taken from DSPX-5117.
@dmihalcik-virtru, a few questions before this merges:
partial_decrypt/http_range_sourcefinal? Per theSupportedFeaturesdoc comment, renaming later has to be coordinated with opentdf/tests, since an unknown string silently skips.cli.shcheck these viasupported_features(likedpop), or would you rather probepartial_decryptwithhelp decrypt | grep -- --offset(likekasallowlist)?http_range_sourcehas no CLI surface (it's a positional argument), so it needs the feature string either way. If you'd prefer the grep forpartial_decrypt, I'll drop it from this list.Checklist
Testing Instructions