Repository navigation
Conversation
WriteTo compared with < when skipping segments before the cursor, so a start offset exactly on a segment boundary read, verified and decrypted the preceding segment only to write zero bytes. Over an HTTP range reader that is a wasted segment fetch per partial decrypt. ReadAt already uses <=. Part of DSPX-4886. Signed-off-by: sujan kota <sujankota@gmail.com>
github-actions
Bot
added
the
comp:sdk
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Benchmark results, click to expandBulk Benchmark Results
TDF3 Benchmark Results
|
Contributor
|
Contributor
dmihalcik-virtru
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Part of DSPX-4886 (found while working on DSPX-5112/5114).
Reader.WriteToskipped segments before the cursor withdecryptedDataOffset+segSize < r.cursor. When the cursor sits exactly on a segment boundary, the segment ending there was not skipped: it was read, hash-checked and decrypted, then written as zero bytes. Output was correct, but over an HTTP range reader (LoadTDFFromURL, #4221) every partial decrypt starting on a boundary costs an extra segment fetch (2 MiB by default) plus a decrypt.ReadAtalready uses<=; this alignsWriteTo.Checklist
Testing Instructions
cd sdk && go test -run 'TestTDF/Test_TDFReaderWriteToSkipsSegmentBeforeBoundary' .loads a 4-segment TDF through a byte-counting reader, seeks to the first boundary and assertsWriteToreads exactly the encrypted bytes of segments 2–4. Before the fix it read one extra segment (49401 vs 32989 bytes). Fullgo test -race ./...insdkpasses, including the existingTest_TDFReaderMultiSegmentSeekReadWriteToboundary cases.