Skip to content

Fix the GitVersionPrerelease output#5

Open
g-galante wants to merge 3 commits into
opentap:mainfrom
g-galante:4-fix-GitVersionPrerelease
Open

Fix the GitVersionPrerelease output#5
g-galante wants to merge 3 commits into
opentap:mainfrom
g-galante:4-fix-GitVersionPrerelease

Conversation

@g-galante

@g-galante g-galante commented Dec 6, 2023

Copy link
Copy Markdown

Resolves #4

Commit 0c7aa05 takes care of the notice GitHub Actions: All Actions will run on Node16 instead of Node12 by default, upgrading all GitHub actions running on Node12 to a version running on Node16 to squelch the warnings.

The (last) remaining warning:
image
will disappear when opentap/setup-opentap#12 is merged and the reference in:

- uses: opentap/setup-opentap@v1.0
is updated accordingly.

I volunteer to push one more commit to this PR to accomplish that when opentap/setup-opentap#12 is merged.

@alnlarsen

Copy link
Copy Markdown
Collaborator

Thanks, @g-galante

It looks like a conflicting commit was added to main. Can you resolve the conflict? Then I think we can go ahead and merge this

@alnlarsen

Copy link
Copy Markdown
Collaborator

Heads up, OpenTAP gitversion behavior will change in the very near future due to this: opentap/opentap#1384

I think we should resolve build warnings, tag v1.1, update OpenTAP with the new behavior, and then tag v2.0

@g-galante g-galante force-pushed the 4-fix-GitVersionPrerelease branch from 0c7aa05 to f63daf1 Compare February 6, 2024 14:50
@g-galante

Copy link
Copy Markdown
Author

Commit 42f0ef0, which you pushed in the morning, is conflicting with commit 0c7aa05, which I had pushed above, because they both modify actions' versions in action.yml. So, it turns out that build warnings have already been fixed by you.

The warnings in action Update setup-opentap (#7) #36 are coming from:

uses: actions/checkout@v2
and
uses: actions/checkout@v2
that still need to be fixed (commit f63daf1).

Do you mean tag v1.2? v1.1 is already there.
image

The documentation has now been updated (commit 366e903) assuming you will tag it as v1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with the GitVersionPrerelease output

2 participants