Skip to content

OCPQE-32079: Replace brittle string split with regex for timestamp extraction for OCP-39845 #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrSanketkumar wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −3
Open

OCPQE-32079: Replace brittle string split with regex for timestamp extraction for OCP-39845 #3934

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8e13c5
Fix OCP-39845 datetime parse error with regex-based timestamp extract…
MrSanketkumar Jun 16, 2026
9d74132
Fix OCP-39845: Extract timestamp using correct format YYYY/MM/DD HH:M…
MrSanketkumar Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions features/step_definitions/file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,27 @@

Given /^I get time difference using "(.+)" and "(.+)" in (.+) file$/ do |s1, s2, filename|
##This isn't a generic step-definition yet & specific to logs of machineset-controller##
split1 = File.open(filename){ |f| f.read }.split(s1)[0].split("Watching")[0]
split2 = File.open(filename){ |f| f.read }.split(s2)[0].split(s1)[2].strip
log_content = File.read(filename)

# Extract timestamp from line containing the marker
# Log format: YYYY/MM/DD HH:MM:SS Message
# Example: 2026/06/16 08:36:17 Registering Components.
match1 = log_content.match(/(\d{4}\/\d{2}\/\d{2}\s+\d{2}:\d{2}:\d{2})\s+#{Regexp.escape(s1)}/)
match2 = log_content.match(/(\d{4}\/\d{2}\/\d{2}\s+\d{2}:\d{2}:\d{2})\s+#{Regexp.escape(s2)}/)

raise "Could not find timestamp for '#{s1}' in log" unless match1
raise "Could not find timestamp for '#{s2}' in log" unless match2

split1 = match1[1]
split2 = match2[1]

#Calculating time difference in seconds
time_start = DateTime.parse split1
time_end = DateTime.parse split2
time_difference = ((time_end - time_start)* 24 * 60 * 60).to_i

if time_difference > 30
raise ("Upgrade can cause issues for new machinesets")
raise ("Upgrade can cause issues for new machinesets (#{time_difference}s > 30s)")
end
end
# This step is used to delete lines from file. If multiline match is needed,
Expand Down