Skip to content

CMP-4475: Add e2e CI job for OCP-Virt cis-vm-extension profile - #81659

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
taimurhafeez:add-jobs-for-compliance-ocp-virt
Aug 31, 2026
Merged

CMP-4475: Add e2e CI job for OCP-Virt cis-vm-extension profile#81659
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
taimurhafeez:add-jobs-for-compliance-ocp-virt

Conversation

@taimurhafeez

@taimurhafeez taimurhafeez commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a new Prow CI job e2e-aws-ocp4-cis-vm-extension for the ComplianceAsCode/ocp4e2e repo
  • Tests the CIS VM Extension compliance profile against an AWS cluster with OpenShift Virtualization (CNV) installed
  • Uses the new -install-virt and -cel-content-file flags from ocp4e2e PR #78

Dependencies

  • Requires ComplianceAsCode/ocp4e2e#78 to be merged first (adds CNV install + CEL content flags)
  • CEL ProfileBundle wiring (vendored compliance-operator API bump to >= v1.9.0) is still in progress — job will not pass until that lands

Test plan

  • Verify job appears in PR checks for ComplianceAsCode/ocp4e2e after merge
  • Manually trigger with /test e2e-aws-ocp4-cis-vm-extension once CEL ProfileBundle support is complete
  • Confirm existing jobs are unaffected

🤖 Generated with Claude Code

Summary by CodeRabbit

Adds a Prow job for ComplianceAsCode/ocp4e2e that runs the cis-vm-extension profile on an AWS OpenShift cluster with OpenShift Virtualization enabled. The job uses the ipi-aws workflow, quay-aws cluster profile, and ocp4-cel-content.yaml CEL content file.

The job depends on upstream ocp4e2e support for -install-virt and -cel-content-file, plus compliance-operator CEL ProfileBundle API support available in at least v1.9.0.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@taimurhafeez: This pull request references CMP-4475 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds a new Prow CI job e2e-aws-ocp4-cis-vm-extension for the ComplianceAsCode/ocp4e2e repo
  • Tests the CIS VM Extension compliance profile against an AWS cluster with OpenShift Virtualization (CNV) installed
  • Uses the new -install-virt and -cel-content-file flags from ocp4e2e PR #78

Dependencies

  • Requires ComplianceAsCode/ocp4e2e#78 to be merged first (adds CNV install + CEL content flags)
  • CEL ProfileBundle wiring (vendored compliance-operator API bump to >= v1.9.0) is still in progress — job will not pass until that lands

Test plan

  • Verify job appears in PR checks for ComplianceAsCode/ocp4e2e after merge
  • Manually trigger with /test e2e-aws-ocp4-cis-vm-extension once CEL ProfileBundle support is complete
  • Confirm existing jobs are unaffected

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5ac72748-0934-4d87-885f-b698392c5f79

📥 Commits

Reviewing files that changed from the base of the PR and between d9bd415 and 668fb54.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/ComplianceAsCode/ocp4e2e/ComplianceAsCode-ocp4e2e-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/ComplianceAsCode/ocp4e2e/ComplianceAsCode-ocp4e2e-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/ComplianceAsCode/ocp4e2e/ComplianceAsCode-ocp4e2e-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

Adds an AWS end-to-end compliance test entry for the OCP4 CIS VM extension profile. The entry configures the cluster profile, environment variables, virtualization setup, command, CPU request, and workflow selection.

Changes

CIS VM extension workflow

Layer / File(s) Summary
CIS VM extension workflow entry
ci-operator/config/ComplianceAsCode/ocp4e2e/ComplianceAsCode-ocp4e2e-main.yaml
Adds the e2e-aws-ocp4-cis-vm-extension test with quay-aws, virtualization installation, CEL content configuration, make e2e-profile, a 100m CPU request, and the ipi-aws workflow.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 668fb

This change adds CI configuration for a new test job; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: yuumasato, vincent056

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the addition of an end-to-end CI job for the OCP-Virt CIS VM extension profile, which matches the main pull request change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS — The pull request changes only CI YAML. It adds a static Prow job name, context, trigger, and target: e2e-aws-ocp4-cis-vm-extension. The command uses fixed profile, product, and content-file v…
Test Structure And Quality ✅ Passed PASS: The PR changes only CI configuration and the generated Prow job. The added commands invoke the external ocp4e2e test workflow; the PR adds no Ginkgo It, BeforeEach, AfterEach, `Eventuall…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only two CI YAML files. The added content defines a Prow job and its ci-operator test command; it adds no Ginkgo It, Describe, Context, or When tests. Therefor…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request adds only Prow/ci-operator YAML. The diff adds a workflow and generated presubmit job; it adds no Go files or Ginkgo declarations such as It(), Describe(), Context(), or When().…
Topology-Aware Scheduling Compatibility ✅ Passed PASS — The pull request changes only CI operator configuration and generated Prow job wiring. It adds environment variables and runs the existing ipi-aws workflow; it does not add or modify deployme…
Ote Binary Stdout Contract ✅ Passed PASS. The diff adds only YAML configuration and a generated Prow job. The new command invokes make e2e-profile; it adds no OTE binary source, suite setup, initializer, or process-level stdout write.…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS — The pull request adds only CI YAML configuration and a generated Prow job. The diff contains no new Ginkgo test code, IPv4 literals or parsing, CIDRs, IP-family checks, URL construction, downlo…
No-Weak-Crypto ✅ Passed PASS: The pull request changes only two YAML configuration files. The added job invokes an existing test workflow and mounts standard CI secrets; it adds no MD5, SHA-1, DES, RC4, 3DES, Blowfish, ECB, …
Container-Privileges ✅ Passed The pull request adds a test definition and its generated Prow presubmit job. The changed YAML contains no privileged: true, hostPID, hostNetwork, hostIPC, allowPrivilegeEscalation: true, `S…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request adds one Prow workflow and its generated job. The new command exports profile and feature flags and runs make e2e-profile; it adds no echo, printf, logger, or other explic…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS — The pull request changes only CI YAML. It adds a static Prow job name, context, trigger, and target: e2e-aws-ocp4-cis-vm-extension. The command uses fixed profile, product, and content-file values. It adds no Ginkgo It, Describe, Context, or When test title, and no dynamic value appears in a test title.

Full details: Test Structure And Quality

Explanation

PASS: The PR changes only CI configuration and the generated Prow job. The added commands invoke the external ocp4e2e test workflow; the PR adds no Ginkgo It, BeforeEach, AfterEach, Eventually, Consistently, or assertion code. Therefore the listed Ginkgo test-quality requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only two CI YAML files. The added content defines a Prow job and its ci-operator test command; it adds no Ginkgo It, Describe, Context, or When tests. Therefore, the MicroShift test compatibility check does not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request adds only Prow/ci-operator YAML. The diff adds a workflow and generated presubmit job; it adds no Go files or Ginkgo declarations such as It(), Describe(), Context(), or When(). The changed files contain no multi-node assumptions or SNO guards. Therefore, the SNO test compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS — The pull request changes only CI operator configuration and generated Prow job wiring. It adds environment variables and runs the existing ipi-aws workflow; it does not add or modify deployment manifests, operator code, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. Therefore, it introduces no scheduling constraint covered by this check.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The diff adds only YAML configuration and a generated Prow job. The new command invokes make e2e-profile; it adds no OTE binary source, suite setup, initializer, or process-level stdout write. No changed line can corrupt openshift-tests JSON output under this check.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request adds only CI YAML configuration and a generated Prow job. The diff contains no new Ginkgo test code, IPv4 literals or parsing, CIDRs, IP-family checks, URL construction, download commands, or public endpoint references. The added quay-aws, quay.devcluster.openshift.com, and quay-proxy.ci.openshift.org values configure the CI cluster and proxy; they do not introduce a flagged test assumption.

Full details: No-Weak-Crypto

Explanation

PASS: The pull request changes only two YAML configuration files. The added job invokes an existing test workflow and mounts standard CI secrets; it adds no MD5, SHA-1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret/token comparison. The exact search over all introduced lines found no weak-crypto usage.

Full details: Container-Privileges

Explanation

The pull request adds a test definition and its generated Prow presubmit job. The changed YAML contains no privileged: true, hostPID, hostNetwork, hostIPC, allowPrivilegeEscalation: true, SYS_ADMIN, or capability declaration. It also adds no runAsUser: 0 or runAsNonRoot: false. The new job uses the same standard ci-operator container structure as adjacent jobs and does not introduce a container security context.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request adds one Prow workflow and its generated job. The new command exports profile and feature flags and runs make e2e-profile; it adds no echo, printf, logger, or other explicit logging. It contains no password, token, API key, PII, session ID, or customer data. The BASE_DOMAIN value is a pre-existing CI configuration pattern, not a logged sensitive value. Secret references in the generated Prow job point to mounted CI secrets and do not expose their contents.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added rehearsals-ack Signifies that rehearsal jobs have been acknowledged and removed rehearsals-ack Signifies that rehearsal jobs have been acknowledged labels Jul 9, 2026
- as: test
cli: latest
commands: |
export SKIP_CONTAINER_PUSH=true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SKIP_CONTAINER_PUSH is a no-op here — ocp4e2e removed support for it back in 2021 (f78461e, "Remove SKIP_CONTAINER_PUSH support"), and current main doesn't read it anywhere. It's copied from the other lanes, so it's harmless, but has no effect on this job. Not blocking — we could drop it from all the ocp4e2e lanes in a separate cleanup PR.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2026
@taimurhafeez
taimurhafeez force-pushed the add-jobs-for-compliance-ocp-virt branch from d9d4cbf to 173a829 Compare July 16, 2026 09:01
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2026
@Vincent056

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Vincent056: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 21, 2026
@taimurhafeez
taimurhafeez marked this pull request as ready for review July 21, 2026 10:23
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@openshift-ci
openshift-ci Bot requested review from Vincent056 and yuumasato July 21, 2026 10:25
@Vincent056

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Vincent056: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rhmdnd

rhmdnd commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Failure seems specific to profile construction, which is outside this PR and something we can fix in the content repo I think.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2026
@taimurhafeez

Copy link
Copy Markdown
Contributor Author

/test release-controller-config

@taimurhafeez

Copy link
Copy Markdown
Contributor Author

/retest-required

@taimurhafeez

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@taimurhafeez

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-cis-vm-extension

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@taimurhafeez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@taimurhafeez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@taimurhafeez

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-cis-vm-extension

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@taimurhafeez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@taimurhafeez
taimurhafeez force-pushed the add-jobs-for-compliance-ocp-virt branch from 173a829 to 668fb54 Compare August 31, 2026 13:00
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@taimurhafeez: This pull request references CMP-4475 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds a new Prow CI job e2e-aws-ocp4-cis-vm-extension for the ComplianceAsCode/ocp4e2e repo
  • Tests the CIS VM Extension compliance profile against an AWS cluster with OpenShift Virtualization (CNV) installed
  • Uses the new -install-virt and -cel-content-file flags from ocp4e2e PR #78

Dependencies

  • Requires ComplianceAsCode/ocp4e2e#78 to be merged first (adds CNV install + CEL content flags)
  • CEL ProfileBundle wiring (vendored compliance-operator API bump to >= v1.9.0) is still in progress — job will not pass until that lands

Test plan

  • Verify job appears in PR checks for ComplianceAsCode/ocp4e2e after merge
  • Manually trigger with /test e2e-aws-ocp4-cis-vm-extension once CEL ProfileBundle support is complete
  • Confirm existing jobs are unaffected

🤖 Generated with Claude Code

Summary by CodeRabbit

Adds a Prow job for ComplianceAsCode/ocp4e2e that runs the cis-vm-extension profile on an AWS OpenShift cluster with OpenShift Virtualization enabled. The job uses the ipi-aws workflow, quay-aws cluster profile, and ocp4-cel-content.yaml CEL content file.

The job depends on upstream ocp4e2e support for -install-virt and -cel-content-file, plus compliance-operator CEL ProfileBundle API support available in at least v1.9.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 31, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@taimurhafeez: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-cis-vm-extension ComplianceAsCode/ocp4e2e presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@taimurhafeez: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuumasato yuumasato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 31, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2026
@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, taimurhafeez, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 728006c into openshift:main Aug 31, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants