CMP-4475: Add e2e CI job for OCP-Virt cis-vm-extension profile - #81659
Conversation
|
@taimurhafeez: This pull request references CMP-4475 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughAdds an AWS end-to-end compliance test entry for the OCP4 CIS VM extension profile. The entry configures the cluster profile, environment variables, virtualization setup, command, CPU request, and workflow selection. ChangesCIS VM extension workflow
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change adds CI configuration for a new test job; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS — The pull request changes only CI YAML. It adds a static Prow job name, context, trigger, and target: Full details: Test Structure And QualityExplanation PASS: The PR changes only CI configuration and the generated Prow job. The added commands invoke the external Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only two CI YAML files. The added content defines a Prow job and its Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request adds only Prow/ci-operator YAML. The diff adds a workflow and generated presubmit job; it adds no Go files or Ginkgo declarations such as It(), Describe(), Context(), or When(). The changed files contain no multi-node assumptions or SNO guards. Therefore, the SNO test compatibility check is not applicable. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS — The pull request changes only CI operator configuration and generated Prow job wiring. It adds environment variables and runs the existing Full details: Ote Binary Stdout ContractExplanation PASS. The diff adds only YAML configuration and a generated Prow job. The new command invokes Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS — The pull request adds only CI YAML configuration and a generated Prow job. The diff contains no new Ginkgo test code, IPv4 literals or parsing, CIDRs, IP-family checks, URL construction, download commands, or public endpoint references. The added Full details: No-Weak-CryptoExplanation PASS: The pull request changes only two YAML configuration files. The added job invokes an existing test workflow and mounts standard CI secrets; it adds no MD5, SHA-1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret/token comparison. The exact search over all introduced lines found no weak-crypto usage. Full details: Container-PrivilegesExplanation The pull request adds a test definition and its generated Prow presubmit job. The changed YAML contains no Full details: No-Sensitive-Data-In-LogsExplanation PASS: The pull request adds one Prow workflow and its generated job. The new command exports profile and feature flags and runs ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
| - as: test | ||
| cli: latest | ||
| commands: | | ||
| export SKIP_CONTAINER_PUSH=true |
There was a problem hiding this comment.
SKIP_CONTAINER_PUSH is a no-op here — ocp4e2e removed support for it back in 2021 (f78461e, "Remove SKIP_CONTAINER_PUSH support"), and current main doesn't read it anywhere. It's copied from the other lanes, so it's harmless, but has no effect on this job. Not blocking — we could drop it from all the ocp4e2e lanes in a separate cleanup PR.
d9d4cbf to
173a829
Compare
|
/pj-rehearse ack |
|
@Vincent056: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@Vincent056: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Failure seems specific to profile construction, which is outside this PR and something we can fix in the content repo I think. /lgtm |
|
/test release-controller-config |
|
/retest-required |
|
/pj-rehearse |
|
/pj-rehearse pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-cis-vm-extension |
|
@taimurhafeez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@taimurhafeez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-ComplianceAsCode-ocp4e2e-main-e2e-aws-ocp4-cis-vm-extension |
|
@taimurhafeez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
173a829 to
668fb54
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@taimurhafeez: This pull request references CMP-4475 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@taimurhafeez: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@yuumasato: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, taimurhafeez, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
e2e-aws-ocp4-cis-vm-extensionfor the ComplianceAsCode/ocp4e2e repo-install-virtand-cel-content-fileflags from ocp4e2e PR #78Dependencies
Test plan
ComplianceAsCode/ocp4e2eafter merge/test e2e-aws-ocp4-cis-vm-extensiononce CEL ProfileBundle support is complete🤖 Generated with Claude Code
Summary by CodeRabbit
Adds a Prow job for
ComplianceAsCode/ocp4e2ethat runs thecis-vm-extensionprofile on an AWS OpenShift cluster with OpenShift Virtualization enabled. The job uses theipi-awsworkflow,quay-awscluster profile, andocp4-cel-content.yamlCEL content file.The job depends on upstream
ocp4e2esupport for-install-virtand-cel-content-file, plus compliance-operator CEL ProfileBundle API support available in at least v1.9.0.