monitoring-plugin: enable alert-management-api feature in e2e step#80962
Conversation
WalkthroughThe monitoring-plugin release CI configs remove the ChangesMonitoring Plugin CI and Test Command Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse |
|
@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
Enable the alert-management-api feature flag in the e2e step script so management routes are registered during tests. Also remove the e2e-management-api job from release-4.23, release-5.0, and release-5.1 configs since the management API code only exists on the main-alerts-management-api branch. Signed-off-by: Shirly Radco <sradco@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
4b93f00 to
78d2b15
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PeterYurkovich, simonpasquier, sradco The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse |
|
@PeterYurkovich: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PeterYurkovich note that the rehearse won't succeed because the tests are only implemented in the feature branch. |
|
/pj-rehearse ack |
|
@PeterYurkovich: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sradco: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
26d6fb5
into
openshift:main
Summary
alert-management-apifeature flag in the e2e-management-api CI step script so management routes are registered during testse2e-management-apijob from release-4.23, release-5.0, and release-5.1 configs since the management API code only exists on themain-alerts-management-apibranchCompanion PR
Test plan
/test e2e-management-apipasses on monitoring-plugin PR Bind to correct admin role #976 after both PRs mergeSigned-off-by: Shirly Radco sradco@redhat.com