Skip to content

monitoring-plugin: enable alert-management-api feature in e2e step#80962

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
sradco:monitoring-plugin-management-api-e2e
Jun 24, 2026
Merged

monitoring-plugin: enable alert-management-api feature in e2e step#80962
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
sradco:monitoring-plugin-management-api-e2e

Conversation

@sradco

@sradco sradco commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Enable the alert-management-api feature flag in the e2e-management-api CI step script so management routes are registered during tests
  • Remove the e2e-management-api job from release-4.23, release-5.0, and release-5.1 configs since the management API code only exists on the main-alerts-management-api branch

Companion PR

Test plan

Signed-off-by: Shirly Radco sradco@redhat.com

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The monitoring-plugin release CI configs remove the e2e-management-api job, and the management API test script now starts the backend with the alert-management-api feature flag.

Changes

Monitoring Plugin CI and Test Command Updates

Layer / File(s) Summary
Remove management API job from release configs
ci-operator/config/openshift/monitoring-plugin/openshift-monitoring-plugin-release-4.23.yaml, ci-operator/config/openshift/monitoring-plugin/openshift-monitoring-plugin-release-5.0.yaml, ci-operator/config/openshift/monitoring-plugin/openshift-monitoring-plugin-release-5.1.yaml
The e2e-management-api job block is removed from the release pipelines, and the sequence now goes from e2e-alerts to e2e-dashboards.
Update backend launch flags
ci-operator/step-registry/monitoring-plugin/tests/management-api/monitoring-plugin-tests-management-api-commands.sh
The backend command adds -features='alert-management-api', and & is moved to background the command after that flag.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#80835: Also changes the monitoring-plugin e2e-management-api CI behavior in the OpenShift release pipeline.

Suggested labels

approved, rehearsals-ack

Suggested reviewers

  • jgbernalp
  • etmurasaki
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the key script change to add the alert-management-api feature in the e2e management API step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified; the PR only changes a backend startup script and CI job config.
Test Structure And Quality ✅ Passed No Ginkgo test code was changed; the PR only updates CI YAML and a backend-start shell script.
Microshift Test Compatibility ✅ Passed This PR only adjusts CI step commands/config and removes jobs; it adds no new Ginkgo e2e tests or OpenShift API usage to review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only CI config and a shell startup command changed; no new Ginkgo e2e tests were added, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Changes only adjust CI step/YAML job registration and add a feature flag; no pod specs, affinity, nodeSelectors, replicas, or PDBs were introduced.
Ote Binary Stdout Contract ✅ Passed No process-level code was changed; the PR only updates a step-registry shell script and CI YAML, so it doesn't add stdout writes in main/init/TestMain/suite setup.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; changed files only tweak CI config and local backend startup, with no IPv4-only or public-internet dependencies.
No-Weak-Crypto ✅ Passed Changed files are CI shell/YAML only; scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret/token comparisons.
Container-Privileges ✅ Passed Touched monitoring-plugin files only add a feature flag and remove jobs; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings were found.
No-Sensitive-Data-In-Logs ✅ Passed The only logging added is generic status output; no passwords, tokens, PII, hostnames, or customer data are printed.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@simonpasquier

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@simonpasquier

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2026
Enable the alert-management-api feature flag in the e2e step script
so management routes are registered during tests.

Also remove the e2e-management-api job from release-4.23, release-5.0,
and release-5.1 configs since the management API code only exists on
the main-alerts-management-api branch.

Signed-off-by: Shirly Radco <sradco@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@sradco sradco force-pushed the monitoring-plugin-management-api-e2e branch from 4b93f00 to 78d2b15 Compare June 24, 2026 12:26
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@sradco: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-monitoring-plugin-main-e2e-management-api openshift/monitoring-plugin presubmit Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@PeterYurkovich

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2026
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich, simonpasquier, sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026
@PeterYurkovich

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@PeterYurkovich: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@simonpasquier

Copy link
Copy Markdown
Contributor

@PeterYurkovich note that the rehearse won't succeed because the tests are only implemented in the feature branch.

@PeterYurkovich

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@PeterYurkovich: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 24, 2026
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@sradco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/monitoring-plugin/main/e2e-management-api 78d2b15 link unknown /pj-rehearse pull-ci-openshift-monitoring-plugin-main-e2e-management-api
ci/rehearse/openshift/monitoring-plugin/release-5.1/e2e-management-api 4b93f00 link unknown /pj-rehearse pull-ci-openshift-monitoring-plugin-release-5.1-e2e-management-api
ci/rehearse/openshift/monitoring-plugin/release-5.0/e2e-management-api 4b93f00 link unknown /pj-rehearse pull-ci-openshift-monitoring-plugin-release-5.0-e2e-management-api
ci/rehearse/openshift/monitoring-plugin/release-4.23/e2e-management-api 4b93f00 link unknown /pj-rehearse pull-ci-openshift-monitoring-plugin-release-4.23-e2e-management-api

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 26d6fb5 into openshift:main Jun 24, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants