OCPBUGS-63307: Fix image policy event intervals and bookkeeping#30991
OCPBUGS-63307: Fix image policy event intervals and bookkeeping#30991haircommander wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
jira/valid-reference
|
@haircommander: This pull request references Jira Issue OCPBUGS-63307, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThree Sigstore-related event matcher functions had their buffered overlap windows increased from ±30 seconds to ±30 minutes and a blank line was inserted after each Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Scheduling required tests: |
|
The increase the intervals commit looks good. Waiting on possible rework on the deferclean up commit. |
haircommander
force-pushed
the
image-policy-intervals
branch
from
248685a to
46ee5b7
Compare
|
/lgtm |
|
@haircommander: This pull request references Jira Issue OCPBUGS-63307, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial |
|
@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a488aa10-34b9-11f1-9ef8-5eddfc43811b-0 |
|
/payload-job periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-techpreview-serial |
|
@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b01b0170-34b9-11f1-8baa-b6739f6b7d46-0 |
|
Test case |
haircommander
force-pushed
the
image-policy-intervals
branch
from
46ee5b7 to
960bfdf
Compare
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial |
|
@haircommander: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2d8c3cf0-3505-11f1-9adb-e9ec8aa322fd-0 |
|
Scheduling required tests: |
|
I think maybe we need to increse the inverval to +/- 30min, above 4.21-e2e-azure-ovn-techpreview-serial test failure |
All of the other intervals are around 10 minutes. These events are triggered by MCP rollout, which happens for each of the image policy tests. By observation, MCP rollouts can take upwards of 30 minutes, so we need to ignore for that duration Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
image-policy-intervals
branch
from
960bfdf to
a2c00b9
Compare
|
updated @QiWang19 |
|
@haircommander: This pull request references Jira Issue OCPBUGS-63307, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (bgudi@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial |
|
@QiWang19: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26713880-3758-11f1-836a-b96fda2dbbbb-0 |
|
Scheduling required tests: |
|
Tests failed to install at https://pr-payload-tests.ci.openshift.org/runs/ci/26713880-3758-11f1-836a-b96fda2dbbbb-0, will trigger a rerun. /lgtm |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial |
|
@QiWang19: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d612edc0-3806-11f1-8913-39937e9c5160-0 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cpmeadors, haircommander, QiWang19 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/skip |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial |
|
@haircommander: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6648ed30-383a-11f1-8583-9f27bbce5451-0 |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3 |
|
@QiWang19: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/379bc490-38d9-11f1-916c-1c6988fa2db6-0 |
| AddSigtermProtectionIntervals[i].To = AddSigtermProtectionIntervals[i].To.Add(time.Second * 30) | ||
| AddSigtermProtectionIntervals[i].From = AddSigtermProtectionIntervals[i].From.Add(time.Second * -30) | ||
| AddSigtermProtectionIntervals[i].To = AddSigtermProtectionIntervals[i].To.Add(time.Minute * 30) | ||
| AddSigtermProtectionIntervals[i].From = AddSigtermProtectionIntervals[i].From.Add(time.Minute * -30) |
There was a problem hiding this comment.
| AddSigtermProtectionIntervals[i].From = AddSigtermProtectionIntervals[i].From.Add(time.Minute * -30) | |
| AddSigtermProtectionIntervals[i].From = AddSigtermProtectionIntervals[i].From.Add(time.Second * -30) |
I suggest we keep the From time as the original value, since we don't need such a long time window before the test run.
| RemoveSigtermProtectionIntervals[i].To = RemoveSigtermProtectionIntervals[i].To.Add(time.Second * 30) | ||
| RemoveSigtermProtectionIntervals[i].From = RemoveSigtermProtectionIntervals[i].From.Add(time.Second * -30) | ||
| RemoveSigtermProtectionIntervals[i].To = RemoveSigtermProtectionIntervals[i].To.Add(time.Minute * 30) | ||
| RemoveSigtermProtectionIntervals[i].From = RemoveSigtermProtectionIntervals[i].From.Add(time.Minute * -30) |
There was a problem hiding this comment.
| RemoveSigtermProtectionIntervals[i].From = RemoveSigtermProtectionIntervals[i].From.Add(time.Minute * -30) | |
| RemoveSigtermProtectionIntervals[i].From = RemoveSigtermProtectionIntervals[i].From.Add(time.Second * -30) |
| for i := range configDriftMonitorStoppedIntervals { | ||
| configDriftMonitorStoppedIntervals[i].To = configDriftMonitorStoppedIntervals[i].To.Add(time.Second * 30) | ||
| configDriftMonitorStoppedIntervals[i].From = configDriftMonitorStoppedIntervals[i].From.Add(time.Second * -30) | ||
| configDriftMonitorStoppedIntervals[i].To = configDriftMonitorStoppedIntervals[i].To.Add(time.Minute * 30) |
There was a problem hiding this comment.
It feels wrong that we would need so much grace here. I want to review the event and understand why from doesn't reflect firstTimestamp &/ why the code looking for overlap isn't using firstTimestamp
"message": {
"reason": "AddSigtermProtection",
"cause": "",
"humanMessage": "Adding SIGTERM protection",
"annotations": {
"count": "23",
"firstTimestamp": "2026-04-10T12:15:17Z",
"interesting": "true",
"lastTimestamp": "2026-04-10T13:45:34Z",
"pathological": "true",
"reason": "AddSigtermProtection",
"roles": "infra,worker"
}
},
"from": "2026-04-10T13:45:34Z",
"to": "2026-04-10T13:45:35Z"
6 participants
Assisted by Claude.
All of the other intervals are around 10 minutes. These events are triggered by MCP rollout, which happens for each of the image policy tests.
10 minutes is actually on the lower end for MCP rollout (which is given 20 minutes before timing out), but let's start with this and increase
in the future if necessary
Summary by CodeRabbit
Note: This release contains internal testing improvements with no user-facing changes.