Skip to content

OCPBUGS-94165: Upgrade brace-expansion to 5.0.7 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcbailey wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −72
Open

OCPBUGS-94165: Upgrade brace-expansion to 5.0.7 #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 24 additions & 71 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
"word-wrap": "^1.2.5"
},
"overrides": {
"brace-expansion": "5.0.7",
"@parcel/watcher": "2.5.1",
"qs": "6.14.2",
"fast-uri": "3.1.2"
Expand Down
2 changes: 1 addition & 1 deletion start-console.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ for arg in "$@"; do
cd "$BASE_DIR"
done

CONSOLE_IMAGE=${CONSOLE_IMAGE:-"quay.io/openshift/origin-console:latest"}
CONSOLE_IMAGE=${CONSOLE_IMAGE:-"quay.io/openshift/origin-console:4.22"}

@coderabbitai coderabbitai Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== start-console.sh ==\n'
nl -ba start-console.sh | sed -n '60,80p'

printf '\n== README.md mentions of CONSOLE_IMAGE/origin-console ==\n'
rg -n 'CONSOLE_IMAGE|origin-console|latest|4\.22' README.md

Repository: openshift/nmstate-console-plugin

Length of output: 234

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== start-console.sh ==\n'
sed -n '60,80p' start-console.sh | awk '{printf "%6d  %s\n", NR+59, $0}'

printf '\n== README.md mentions of CONSOLE_IMAGE/origin-console ==\n'
rg -n 'CONSOLE_IMAGE|origin-console|latest|4\.22' README.md

Repository: openshift/nmstate-console-plugin

Length of output: 1431

Keep the console image default in sync

start-console.sh defaults to quay.io/openshift/origin-console:4.22, but README.md still says ...:latest. Update the docs or the script so the published default matches.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@start-console.sh` at line 71, The console image default is out of sync
between the startup script and the documentation. Update either the
CONSOLE_IMAGE default in start-console.sh or the README’s published default so
they match, and make sure the referenced default value is consistent across the
start-console.sh logic and any user-facing docs.

CONSOLE_PORT=${CONSOLE_PORT:-9000}

echo "Starting local OpenShift console..."
Expand Down