Adding a new notification for AWS marketplace subscription acknowledgement

[chamalabey]

CCS customers have to acknowledge and accept AWS agreement.

Summary by CodeRabbit

• New Features
  • Added a user-facing notification for blocked cluster machine creation when an AWS Marketplace subscription is required.
  • Included subscription guidance and visibility settings for the acknowledgement.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chamalabey
Once this PR has been reviewed and has the lgtm label, please assign krishvoor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a7115cc-22ed-415e-89e2-a02262ab08b3

📥 Commits

Reviewing files that changed from the base of the PR and between f838c92 and 18adb98.

📒 Files selected for processing (1)

• osd/aws/AWS_Marketplace_acknowledgement.json

---

Walkthrough

The change adds an AWS Marketplace acknowledgement payload for blocked cluster machine creation. The payload defines notification metadata, subscription guidance, and public visibility.

Changes

AWS Marketplace acknowledgement

Layer / File(s)	Summary
Acknowledgement configuration osd/aws/AWS_Marketplace_acknowledgement.json	Adds major severity, SREManualAction service classification, cluster-lifecycle log type, ${AWS_MARKETPLACE_URL} subscription guidance, and internal_only set to false.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the addition of an AWS Marketplace subscription acknowledgement notification.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request adds only a JSON acknowledgement configuration; it contains no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality	✅ Passed	The commit adds only one JSON notification file and changes no Ginkgo tests, so the listed test-structure requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The pull request adds only a JSON notification configuration; it adds no Ginkgo tests or test references to MicroShift-incompatible APIs or features.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The change adds only an AWS Marketplace JSON configuration. It adds no Ginkgo e2e tests or multi-node assumptions, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The change adds only an AWS Marketplace acknowledgement JSON notification. It contains no manifests, controllers, replicas, affinity, topology, node selectors, tolerations, or disruption settings.
Ote Binary Stdout Contract	✅ Passed	The PR changes only one valid JSON configuration file; no executable code, OTE binary, suite setup, or process-level stdout write changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The pull request adds only one JSON notification file. It adds no Ginkgo e2e tests or IPv4 and external-connectivity logic.
No-Weak-Crypto	✅ Passed	The commit adds only a JSON notification. It contains no weak-crypto algorithms, crypto APIs, custom cryptography, or secret/token comparisons.
Container-Privileges	✅ Passed	The patch adds only a valid notification JSON file with no container, Kubernetes, or privilege-related fields.
No-Sensitive-Data-In-Logs	✅ Passed	The notification contains generic AWS Marketplace guidance and a URL placeholder, with no passwords, tokens, keys, PII, hostnames, session IDs, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[krishvoor]

/retest

[openshift-ci]

@chamalabey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/validate	18adb98	link	true	/test validate
ci/prow/checklinks-pr	18adb98	link	false	/test checklinks-pr

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.