konflux: trigger rebuild on code change and pipeline change only#85
Conversation
Signed-off-by: Haoyu Sun <hasun@redhat.com>
📝 WalkthroughSummary by CodeRabbit
WalkthroughBoth Tekton ChangesTekton CEL Path Filtering
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/lightspeed-agentic-sandbox-pull-request.yaml:
- Around line 12-18: Add the missing Tekton push pipeline YAML to the PR path
filter so pipeline-only updates are validated; update the change-matching
expression in lightspeed-agentic-sandbox-pull-request trigger to include both
`.tekton/lightspeed-agentic-sandbox-pull-request.yaml` and
`.tekton/lightspeed-agentic-sandbox-push.yaml`, keeping the existing
`pathChanged()` pattern consistent with the other file checks.
In @.tekton/lightspeed-agentic-sandbox-push.yaml:
- Around line 11-17: The push trigger path filter is missing the PR pipeline
Tekton YAML, so updates to the pipeline definition can still be skipped on main
pushes. Update the path list in the main-branch condition to include both
`.tekton/lightspeed-agentic-sandbox-push.yaml` and
`.tekton/lightspeed-agentic-sandbox-pull-request.yaml`, keeping the existing
pathChanged checks in the trigger expression.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c37caacf-da5b-4af8-b281-59fccab3799d
📒 Files selected for processing (2)
.tekton/lightspeed-agentic-sandbox-pull-request.yaml.tekton/lightspeed-agentic-sandbox-push.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-operator(manual)
| == "main" && ("Containerfile".pathChanged() || "src/***".pathChanged() | ||
| || "pyproject.toml".pathChanged() || "README.md".pathChanged() | ||
| || "LICENSE".pathChanged() || "requirements*.txt".pathChanged() | ||
| || "package.json".pathChanged() || "package-lock.json".pathChanged() | ||
| || "rpms.in.yaml".pathChanged() || "rpms.lock.yaml".pathChanged() | ||
| || "ubi.repo".pathChanged() || "artifacts.lock.yaml".pathChanged() | ||
| || ".tekton/lightspeed-agentic-sandbox-pull-request.yaml".pathChanged()) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Add the push pipeline YAML to this PR filter.
A PR that changes only .tekton/lightspeed-agentic-sandbox-push.yaml will not match this trigger, so pipeline-only changes still skip PR validation. Include both Tekton YAMLs here.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.tekton/lightspeed-agentic-sandbox-pull-request.yaml around lines 12 - 18,
Add the missing Tekton push pipeline YAML to the PR path filter so pipeline-only
updates are validated; update the change-matching expression in
lightspeed-agentic-sandbox-pull-request trigger to include both
`.tekton/lightspeed-agentic-sandbox-pull-request.yaml` and
`.tekton/lightspeed-agentic-sandbox-push.yaml`, keeping the existing
`pathChanged()` pattern consistent with the other file checks.
| == "main" && ("Containerfile".pathChanged() || "src/***".pathChanged() | ||
| || "pyproject.toml".pathChanged() || "README.md".pathChanged() | ||
| || "LICENSE".pathChanged() || "requirements*.txt".pathChanged() | ||
| || "package.json".pathChanged() || "package-lock.json".pathChanged() | ||
| || "rpms.in.yaml".pathChanged() || "rpms.lock.yaml".pathChanged() | ||
| || "ubi.repo".pathChanged() || "artifacts.lock.yaml".pathChanged() | ||
| || ".tekton/lightspeed-agentic-sandbox-push.yaml".pathChanged()) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Add the PR pipeline YAML to this push filter.
A main push that changes only .tekton/lightspeed-agentic-sandbox-pull-request.yaml will not match this trigger, so pipeline-only changes are still skipped after merge. Include both Tekton YAMLs in the path list.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.tekton/lightspeed-agentic-sandbox-push.yaml around lines 11 - 17, The push
trigger path filter is missing the PR pipeline Tekton YAML, so updates to the
pipeline definition can still be skipped on main pushes. Update the path list in
the main-branch condition to include both
`.tekton/lightspeed-agentic-sandbox-push.yaml` and
`.tekton/lightspeed-agentic-sandbox-pull-request.yaml`, keeping the existing
pathChanged checks in the trigger expression.
|
@raptorsun: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.