Skip to content

konflux: trigger rebuild on code change and pipeline change only#85

Merged
raptorsun merged 2 commits into
openshift:mainfrom
raptorsun:pipeline-trigger
Jul 1, 2026
Merged

konflux: trigger rebuild on code change and pipeline change only#85
raptorsun merged 2 commits into
openshift:mainfrom
raptorsun:pipeline-trigger

Conversation

@raptorsun

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Haoyu Sun <hasun@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated automated pipeline triggers so checks run only on the main branch when relevant files have changed.
    • Reduced unnecessary runs by narrowing what changes activate the sandbox and push workflows.

Walkthrough

Both Tekton PipelineRun trigger annotations (pipelinesascode.tekton.dev/on-cel-expression) are updated to add a pathChanged() disjunction, restricting execution to when specific files or directories change in addition to the existing branch match.

Changes

Tekton CEL Path Filtering

Layer / File(s) Summary
CEL expression path filtering
.tekton/lightspeed-agentic-sandbox-pull-request.yaml, .tekton/lightspeed-agentic-sandbox-push.yaml
Both pipelines extend their on-cel-expression with a pathChanged() disjunction covering Containerfile, src/***, pyproject.toml, lock/dependency files, RPM/UBI files, and the pipeline YAML itself.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No meaningful PR description was provided, so the intent can't be assessed from the author text alone. Add a brief description of the rebuild trigger changes and the affected Tekton PipelineRun files.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: rebuilds now trigger only on code or pipeline changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from blublinsky and onmete June 26, 2026 14:52
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raptorsun

Copy link
Copy Markdown
Contributor Author

/retest

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.tekton/lightspeed-agentic-sandbox-pull-request.yaml:
- Around line 12-18: Add the missing Tekton push pipeline YAML to the PR path
filter so pipeline-only updates are validated; update the change-matching
expression in lightspeed-agentic-sandbox-pull-request trigger to include both
`.tekton/lightspeed-agentic-sandbox-pull-request.yaml` and
`.tekton/lightspeed-agentic-sandbox-push.yaml`, keeping the existing
`pathChanged()` pattern consistent with the other file checks.

In @.tekton/lightspeed-agentic-sandbox-push.yaml:
- Around line 11-17: The push trigger path filter is missing the PR pipeline
Tekton YAML, so updates to the pipeline definition can still be skipped on main
pushes. Update the path list in the main-branch condition to include both
`.tekton/lightspeed-agentic-sandbox-push.yaml` and
`.tekton/lightspeed-agentic-sandbox-pull-request.yaml`, keeping the existing
pathChanged checks in the trigger expression.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c37caacf-da5b-4af8-b281-59fccab3799d

📥 Commits

Reviewing files that changed from the base of the PR and between 5bbc89d and b53ad71.

📒 Files selected for processing (2)
  • .tekton/lightspeed-agentic-sandbox-pull-request.yaml
  • .tekton/lightspeed-agentic-sandbox-push.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift/lightspeed-agentic-operator (manual)

Comment on lines +12 to +18
== "main" && ("Containerfile".pathChanged() || "src/***".pathChanged()
|| "pyproject.toml".pathChanged() || "README.md".pathChanged()
|| "LICENSE".pathChanged() || "requirements*.txt".pathChanged()
|| "package.json".pathChanged() || "package-lock.json".pathChanged()
|| "rpms.in.yaml".pathChanged() || "rpms.lock.yaml".pathChanged()
|| "ubi.repo".pathChanged() || "artifacts.lock.yaml".pathChanged()
|| ".tekton/lightspeed-agentic-sandbox-pull-request.yaml".pathChanged())

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Add the push pipeline YAML to this PR filter.

A PR that changes only .tekton/lightspeed-agentic-sandbox-push.yaml will not match this trigger, so pipeline-only changes still skip PR validation. Include both Tekton YAMLs here.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/lightspeed-agentic-sandbox-pull-request.yaml around lines 12 - 18,
Add the missing Tekton push pipeline YAML to the PR path filter so pipeline-only
updates are validated; update the change-matching expression in
lightspeed-agentic-sandbox-pull-request trigger to include both
`.tekton/lightspeed-agentic-sandbox-pull-request.yaml` and
`.tekton/lightspeed-agentic-sandbox-push.yaml`, keeping the existing
`pathChanged()` pattern consistent with the other file checks.

Comment on lines +11 to +17
== "main" && ("Containerfile".pathChanged() || "src/***".pathChanged()
|| "pyproject.toml".pathChanged() || "README.md".pathChanged()
|| "LICENSE".pathChanged() || "requirements*.txt".pathChanged()
|| "package.json".pathChanged() || "package-lock.json".pathChanged()
|| "rpms.in.yaml".pathChanged() || "rpms.lock.yaml".pathChanged()
|| "ubi.repo".pathChanged() || "artifacts.lock.yaml".pathChanged()
|| ".tekton/lightspeed-agentic-sandbox-push.yaml".pathChanged())

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Add the PR pipeline YAML to this push filter.

A main push that changes only .tekton/lightspeed-agentic-sandbox-pull-request.yaml will not match this trigger, so pipeline-only changes are still skipped after merge. Include both Tekton YAMLs in the path list.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/lightspeed-agentic-sandbox-push.yaml around lines 11 - 17, The push
trigger path filter is missing the PR pipeline Tekton YAML, so updates to the
pipeline definition can still be skipped on main pushes. Update the path list in
the main-branch condition to include both
`.tekton/lightspeed-agentic-sandbox-push.yaml` and
`.tekton/lightspeed-agentic-sandbox-pull-request.yaml`, keeping the existing
pathChanged checks in the trigger expression.

@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@raptorsun raptorsun merged commit 043555a into openshift:main Jul 1, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant