Skip to content

NO-JIRA: Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit#477

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
alebedev87:release-1.2.2
May 28, 2026
Merged

NO-JIRA: Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit#477
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
alebedev87:release-1.2.2

Conversation

@alebedev87
Copy link
Copy Markdown
Contributor

@alebedev87 alebedev87 commented May 27, 2026

Pass the serialized image mirror set via the shared-data workspace instead of a Tekton task result to avoid the 4096-byte size limit. Use the imageContentSourcesFile parameter of eaas-create-ephemeral-cluster-hypershift-aws step action.

Add registry.redhat.io/edo/* mirror entries pointing to Konflux builds, matching the existing registry.stage.redhat.io/edo/* mirrors. This allows the bundle relatedImages to reference registry.redhat.io/edo/* from the start, avoiding the manual registry change to registry.stage.redhat.io.

The `serializedMirrorSetYaml` task result has a 4096-byte limit which
can be exceeded as `images-mirror-set.yaml` grows. Write the serialized
mirror set to `serializedMirrorSetYaml` in the `shared-data` workspace
instead, and use the `imageContentSourcesFile` parameter of
`eaas-create-ephemeral-cluster-hypershift-aws` to pass it to the
`provision-cluster` task.
Mirror `registry.redhat.io/edo/*` repositories to Konflux builds in
`quay.io/redhat-user-workloads`, matching the existing mirrors for
`registry.stage.redhat.io/edo/*`. This allows the bundle
`relatedImages` to reference `registry.redhat.io/edo/*` from the
start, avoiding the manual registry change to `registry.stage.redhat.io`.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

📝 Walkthrough

Walkthrough

This pull request updates Tekton pipeline configuration in two coordinated changes. First, it adds new image digest mirror entries to support external-dns operator images from registry.redhat.io/edo/* with quay.io mirrors for rhel8 and rhel9 variants. Second, it refactors the deploy-fbc-operator pipeline to pass the serialized mirror set configuration via shared workspace instead of task result, updates the Git source for mirror set retrieval, and wires the provision-cluster task to read the mirror configuration from the shared workspace file path.

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All Ginkgo test names in api/v1beta1/webhook_test.go use stable, descriptive strings with no dynamic content (UUIDs, timestamps, pod/node/namespace names, IP addresses).
Test Structure And Quality ✅ Passed No Ginkgo test code in PR. Changes are YAML configuration files for Tekton pipelines and container registry mirrors, not test code.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR; changes are limited to Tekton pipeline YAML configuration files.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests added. PR contains only YAML configuration changes to image mirror and Tekton pipeline files.
Topology-Aware Scheduling Compatibility ✅ Passed Changes are to Tekton CI/CD configuration (.tekton files), not deployment manifests, operator code, or controllers. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed Check is not applicable; PR modifies only YAML configuration files, not Go test code where the stdout contract applies.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds only YAML configuration files (.tekton/images-mirror-set.yaml and .tekton/pipelines/deploy-fbc-operator.yaml), not Ginkgo e2e tests. Check only applies when tests are added.
Description check ✅ Passed The pull request description directly addresses the changes made: passing mirror sets via workspace instead of task results to avoid size limits, and adding registry.redhat.io mirrors for external-dns operator images.
Title check ✅ Passed The title accurately describes the two main changes: adding new registry.redhat.io/edo/* image mirrors and fixing the mirror set size limit by moving from task results (4KB limit) to workspace storage.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from davidesalerno and rfredette May 27, 2026 09:11
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.tekton/pipelines/deploy-fbc-operator.yaml:
- Around line 180-182: The pipeline currently pins the SOURCE_GIT_REPO to a
personal fork URL ("https://github.com/alebedev87/external-dns-operator") and
SOURCE_GIT_REVISION to "release-1.2.2"; revert these to the canonical upstream
repo and a controlled revision parameter by replacing the fork URL with the
upstream repo URL (e.g., the official external-dns-operator repo) and either set
SOURCE_GIT_REVISION to the upstream branch/tag or wire it to a pipeline
parameter/variable so the canonical source and revision are explicitly
controlled (refer to the env names SOURCE_GIT_REPO and SOURCE_GIT_REVISION in
the deploy-fbc-operator.yaml).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e933bea9-32f4-45ab-a09e-6ac9a126432e

📥 Commits

Reviewing files that changed from the base of the PR and between a30288c and 7355bd9.

📒 Files selected for processing (2)
  • .tekton/images-mirror-set.yaml
  • .tekton/pipelines/deploy-fbc-operator.yaml

Comment thread .tekton/pipelines/deploy-fbc-operator.yaml Outdated
@alebedev87 alebedev87 changed the title Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit [WIP] Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit May 27, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2026
@alebedev87 alebedev87 changed the title [WIP] Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit May 27, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2026
@alebedev87 alebedev87 changed the title Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit NO-JIRA: Add registry.redhat.io/edo/* image mirrors and fix mirror set size limit May 28, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@alebedev87: This pull request explicitly references no jira issue.

Details

In response to this:

Pass the serialized image mirror set via the shared-data workspace instead of a Tekton task result to avoid the 4096-byte size limit. Use the imageContentSourcesFile parameter of eaas-create-ephemeral-cluster-hypershift-aws step action.

Add registry.redhat.io/edo/* mirror entries pointing to Konflux builds, matching the existing registry.stage.redhat.io/edo/* mirrors. This allows the bundle relatedImages to reference registry.redhat.io/edo/* from the start, avoiding the manual registry change to registry.stage.redhat.io.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown
Contributor

@grzpiotrowski grzpiotrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2026
Copy link
Copy Markdown
Contributor

@Thealisyed Thealisyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thealisyed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 28, 2026

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9b146ce into openshift:main May 28, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants