Skip to content

[release-4.22] OCPBUGS-98062: E2E: Fix tuned active profile check for wrapped performance profiles#1559

Open
openshift-cherrypick-robot wants to merge 2 commits into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-1549-to-release-4.22
Open

[release-4.22] OCPBUGS-98062: E2E: Fix tuned active profile check for wrapped performance profiles#1559
openshift-cherrypick-robot wants to merge 2 commits into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-1549-to-release-4.22

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 8, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #1549

/assign mrniranjan

mrniranjan added 2 commits July 8, 2026 13:05
@mrniranjan
E2E: Fix tuned active profile check for wrapped performance profiles
1c64666 
Test 37127 read /etc/tuned/active_profile on the node and expected the
performance profile name. That fails when a higher-priority Tuned CR wraps
the PP via include=<pp-profile> (e.g. ran-du-performance), because the
active profile name is the wrapper, not the PP name.

Detect wrapper profiles by scanning Tuned CRs for include=<pp-profile>
and assert Profile.status.tunedProfile via the API instead of pod exec.

Traverse the tuned profile chain

In this commit we are traversing the Tuned profile that contains
includes= and verifying if we can traverse back to Performance Profile

AI Attribution: AIA Human-AI blend, New content, Human-initiated, Reviewed, Cursor 3.0.16 v1.0

Signed-off-by: Niranjan M.R <mniranja@redhat.com>
@mrniranjan
Return bool and error on function signatures
3ff3563 
- Fix Hypershift compatibility: Use DataPlaneClient for listing Tuned CRs
  On Hypershift clusters, tuned objects are on the data plane, not control plane.

- Add error handling: Change function signatures to return (bool, error)
  Return errors for unexpected conditions (cycles, missing profiles, parsing failures)
  while returning (false, nil) for valid "not found" cases.

  Error cases:
  * Cycle detected in profile chain
  * Profile referenced but not found in cluster
  * Chain exceeded maximum depth
  * INI parsing failed

  Valid "not found" case:
  * Profile chain ends without reaching target (false, nil)

- Add logging for better observability:
  * Log when INI parsing fails with the error details
  * Log when profiles have no 'include' key
  * Log when 'include' value is empty
  * Changed dead-end from Warning to Info (it's a normal case)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 8, 2026
Merged
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f07e1ed3-5f99-45fe-b3c4-c4f8220d5fc9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-93863 has been cloned as Jira Issue OCPBUGS-98062. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-98062: E2E: Fix tuned active profile check for wrapped performance profiles

Details

In response to this:

This is an automated cherry-pick of #1549

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-93863: E2E: Fix tuned active profile check for wrapped performance profiles [release-4.22] OCPBUGS-98062: E2E: Fix tuned active profile check for wrapped performance profiles Jul 8, 2026
@openshift-ci openshift-ci Bot requested review from jmencak and yanirq July 8, 2026 13:06
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2026
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-98062, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1549

/assign mrniranjan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mrniranjan

mrniranjan commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-98062, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mrniranjan

mrniranjan commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@mrniranjan: This pull request references Jira Issue OCPBUGS-98062, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-93863 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-93863 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mrniranjan

mrniranjan commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/test e2e-aws-operator

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmencak jmencak Awaiting requested review from jmencak
@yanirq yanirq Awaiting requested review from yanirq

Assignees

@mrniranjan mrniranjan

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @openshift-ci-robot @mrniranjan