SSCSI-245: Rename rotationPollIntervalSeconds to minimumRefreshAge

[chiragkyal]

Summary

Renames CustomSecretRotation.rotationPollIntervalSeconds to
CustomSecretRotation.minimumRefreshAge.

The driver only contacts the secret provider when the cached value is older than this threshold. The new
name makes that intent clear at the API level.

No behaviour change; only the API field name and JSON key are updated.

• See SSCSI-254: Configurable secret rotation and WIF support for SSCSI enhancements#2012 (comment) for the decision.
• Follow up of SSCSI-245: Add Secrets Store CSI driver configuration to ClusterCSIDriver API #2846

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @chiragkyal! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR renames secretsStore.secretRotation.custom.rotationPollIntervalSeconds to minimumRefreshAge in the CustomSecretRotation API type, the generated ClusterCSIDriver CRD manifests, and the operator test YAML. Validation test names and expected error paths are updated to match the new field name.

Possibly related PRs

• openshift/api#2846 — Introduced the SecretsStore custom secret-rotation field that this PR renames from rotationPollIntervalSeconds to minimumRefreshAge.

Suggested reviewers

• mytreya-rh
• everettraven

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main API field rename in the change set.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The changed Ginkgo/YAML test titles are static and descriptive; no generated names, timestamps, UUIDs, or other dynamic values appear.
Test Structure And Quality	✅ Passed	No Ginkgo test code was changed; the touched test YAML is data-only and shows no setup/cleanup or timeout issues.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only renames an API field in YAML/CRD/type definitions, so no MicroShift-incompatible test was introduced.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only renames the API field and updates YAML schema-validation cases, with no SNO assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Only API/CRD/test field rename for secret rotation; no deployment, controller, or scheduling-affecting changes found.
Ote Binary Stdout Contract	✅ Passed	Touched files are a type definition, CRD YAMLs, and test YAML; the Go file only renames a struct field and has no main/init/TestMain or stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; changes are a Go type rename plus CRD/YAML schema updates, with no IPv4 assumptions or external connectivity in executable test code.
No-Weak-Crypto	✅ Passed	Touched files only rename the secret-rotation API field; scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	PR only renames a CRD/API field and updates tests/CRDs; no privileged, hostPID/network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files only rename the API field in type/schema/tests; no log/logger/klog or sensitive-data strings were found in them.
Description check	✅ Passed	The description matches the changes by explaining the field rename from rotationPollIntervalSeconds to minimumRefreshAge and the JSON key update.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@chiragkyal: This pull request references SSCSI-245 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Renames CustomSecretRotation.rotationPollIntervalSeconds to
CustomSecretRotation.minimumRefreshAge.

The driver only contacts the secret provider when the cached value is older than this threshold. The new
name makes that intent clear at the API level.

No behaviour change; only the API field name and JSON key are updated.

See openshift/enhancements#2012 (comment) for the decision.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chiragkyal]

/cc @mytreya-rh

[openshift-ci]

@chiragkyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-crd-schema	97d1613	link	true	/test verify-crd-schema
ci/prow/verify-crdify	97d1613	link	true	/test verify-crdify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.