OCPNODE-4521: Promote AdditionalStorageConfig feature gate to Default

[saschagrunert]

Promote the AdditionalStorageConfig feature gate from
TechPreviewNoUpgrade/DevPreviewNoUpgrade to the Default feature set,
making additional layer stores, image stores, and artifact stores
generally available in OpenShift 5.0.

• Enhancement: OCPNODE-4520: Update enhancement for 5.0 GA target enhancements#2022
• JIRA: https://issues.redhat.com/browse/OCPNODE-4521

cc @haircommander @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@saschagrunert: This pull request references OCPNODE-4521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Promote the AdditionalStorageConfig feature gate from
TechPreviewNoUpgrade/DevPreviewNoUpgrade to the Default feature set,
making additional layer stores, image stores, and artifact stores
generally available in OpenShift 5.0.

• Enhancement: OCPNODE-4520: Update enhancement for 5.0 GA target enhancements#2022
• JIRA: https://issues.redhat.com/browse/OCPNODE-4521

cc @haircommander @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @saschagrunert! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 19628ae4-0502-4b63-bdf4-7557f550d3ee

📥 Commits

Reviewing files that changed from the base of the PR and between 9544e48 and 38fa453.

⛔ Files ignored due to path filters (5)

• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

📒 Files selected for processing (11)

• features.md
• features/features.go
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

💤 Files with no reviewable changes (9)

• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

• features/features.go
• features.md

---

📝 Walkthrough

Walkthrough

This PR updates AdditionalStorageConfig so it is enabled in Default and OKD feature-gate configuration, adds the corresponding enablement in the Go feature-gate definition and defaults documentation, and moves the flag from disabled to enabled lists in four feature-gate manifests. It also removes the release.openshift.io/feature-set: CustomNoUpgrade annotation from the base ContainerRuntimeConfig CRD and deletes the feature-set-specific ContainerRuntimeConfig CRD manifests.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: promoting AdditionalStorageConfig to the Default feature set.
Description check	✅ Passed	The description matches the changeset and explains the promotion from preview to default and its purpose.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Touched files are feature-gate YAML/defs only; no Ginkgo test titles were added or changed, and the Go file change is a static feature-gate enablement list.
Test Structure And Quality	✅ Passed	No Ginkgo or test files were changed; the PR only updates feature-gate/manifests, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	PASS: the PR only updates feature-gate/config manifests and docs; no new Ginkgo e2e tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests were added or modified; the diff only updates feature-gate configs/docs/manifests, so SNO test compatibility is not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	Only feature-gate metadata and CRD payloads changed; no deployment, controller, affinity, nodeSelector, or topology-aware scheduling logic was introduced.
Ote Binary Stdout Contract	✅ Passed	Changed Go files have no main/init/TestMain/RunSpecs blocks or stdout/logging calls; the PR only updates feature-gate and manifest data.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR only updates feature-gate manifests/docs and one feature registration file; no new Ginkgo e2e tests or network/IP assumptions were added.
No-Weak-Crypto	✅ Passed	Touched files are feature-gate YAML/Go and CRD deletions; no weak-crypto, custom crypto, or secret-comparison patterns found.
Container-Privileges	✅ Passed	No changed manifest adds privileged/root, hostPID/Network/IPC, allowPrivilegeEscalation, or SYS_ADMIN; patch grep found none.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files only adjust feature-gate enablement/manifests; no runtime logging code or sensitive-data-bearing log statements were added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[saschagrunert]

The verify-feature-promotion check fails because there are no FeatureGate:AdditionalStorageConfig tagged test runs in Sippy yet. The e2e tests are pending merge in openshift/origin#31083 (approved, CI mostly green). Once that PR merges and accumulates sufficient test history (at least 5 tests per core platform), this check will pass.

[saschagrunert]

/retest

[yuqi-zhang]

Changes themselves looks fine, pending the tests merging and generating signal.

I see the test PR is still WIP, anything holding that up?

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuqi-zhang
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[everettraven]

@saschagrunert This needs a rebase and tests that pass promotion verification to progress further. Feel free to ping me when that is done and this is ready for a review.

[openshift-ci]

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	38fa453	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.