Skip to content

Potential fix for 1 code quality finding #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matteius wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −5
Draft

Potential fix for 1 code quality finding #936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions scripts/contracts/generate.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import {readFile, writeFile, mkdir, readdir, mkdtemp, rm} from 'node:fs/promises';
import {readFile, writeFile, mkdir, readdir, rm} from 'node:fs/promises';
import {execFileSync} from 'node:child_process';
import {fileURLToPath} from 'node:url';
import path from 'node:path';
import os from 'node:os';
import openapiTS, {astToString} from 'openapi-typescript';
import Ajv2020 from 'ajv/dist/2020.js';
import addFormats from 'ajv-formats';
Expand Down Expand Up @@ -145,9 +144,7 @@ async function main() {
}
const files = await generateArtifacts(source, target);
if (check) {
const temp = await mkdtemp(path.join(os.tmpdir(), 'lightnvr-contract-check-'));
try { await writeArtifacts(files, temp); await checkArtifacts(files, outputRoot); }
finally { await rm(temp, {recursive: true, force: true}); }
await checkArtifacts(files, outputRoot);
} else await writeArtifacts(files, outputRoot);
console.log(`${check ? 'Checked' : 'Generated'} ${files.size} contract artifacts (${target})`);
}
Expand Down
Loading