Repository navigation
test(contracts): preserve validated validator export names - #935
Merged
matteius merged 2 commits intoNov 9, 2026
Merged
Conversation
…tofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
matteius
changed the title
matteius
marked this pull request as ready for review
November 9, 2026 00:11
matteius
deleted the
ai-findings-autofix/scripts-contracts-generate.mjs
branch
November 9, 2026 00:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suggested identifier sanitizer renames accepted schema names such as
classfromvalidateclasstovalidate_class, changing the public validator API unnecessarily.Preserve the original names.
validateSourcealready rejects selected schema names outside[A-Za-z][A-Za-z0-9_]*before interpolation, including when exports default to all components. Thevalidateand__contract_prefixes make reserved words valid identifiers.Add regression tests for stable runtime and declaration exports, and rejection of unsafe names for both explicit and default selection. The reserved-word test fails on the original autofix and passes with this correction. No generated artifact changes are needed.
Validation: all 71 contract tooling tests passed, including 38,025 differential validation cases; contract regeneration check and TypeScript check passed.