Repository navigation
fix(webrtc): reject missing candidate output buffers - #934
Merged
Merged
Conversation
…ofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
matteius
changed the title
matteius
marked this pull request as ready for review
November 9, 2026 00:10
matteius
deleted the
ai-findings-autofix/src-utils-webrtc_candidates.c
branch
November 9, 2026 00:11
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nonempty external-candidate list could dereference a NULL output buffer. Reject missing output storage and nonpositive capacity immediately after the existing separator scan, while preserving zero for NULL, empty, and separator-only lists.
Document the output-buffer contract and cover invalid arguments, unchanged output on rejection, duplicate candidates at capacity, and an overflow sentinel.
Validation: the go2rtc process/config test suite passed in normal and AddressSanitizer/UBSan builds (leak detection enabled).