Repository navigation
Fix flaky busy-day timeline contract at 1440px - #931
Merged
Merged
Conversation
The busy-day timeline contract set currentTime=29.8 as soon as the video reported paused=false. paused flips when play() is requested, before the next segment's metadata loads, and the player then seeks to the timeline cursor, overwriting the test's seek. The 1440px case lost that race on main (965df7a) and on #930. Wait for HAVE_CURRENT_DATA with time advancing first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration Tests › Permission-aware API and browser contractsfails on main (965df7a, a workflow-only change) and on #930 with the same test:The test sets
currentTime = 29.8as soon asvideo.pausedis false after advancing to segment 1001.pausedflips the momentplay()is requested, before the new source's metadata loads.TimelinePlayer'sloadedmetadatahandler then seeks to the timeline cursor (≈0 s into the new segment), overwriting the test's seek, so the segment never ends and never advances to 1002. The 390px run usually wins the race; 1440px sometimes loses.The fix waits for
readyState >= HAVE_CURRENT_DATAwithcurrentTime > 0before jumping near the end. Product behavior is unchanged.Test plan
npm run contracts:typecheckPermission-aware API and browser contractsgreen on this PR🤖 Generated with Claude Code