Skip to content

Bound batch deletion polling and encode detection stream paths - #928

Merged
matteius merged 4 commits into
mainfrom
ai-findings-autofix/web-js-components-preact-recordings-recordingsAPI.tsx
Nov 7, 2026
Merged

matteius merged 4 commits into
mainfrom
ai-findings-autofix/web-js-components-preact-recordings-recordingsAPI.tsx

Conversation

@matteius

@matteius matteius commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Batch deletion polling used an attempt count that did not include request latency or internal retries. Even reducing it to 15 attempts could leave callers waiting roughly ten minutes. Detection requests also interpolated unescaped stream names into URL paths.

Use a two-minute elapsed-time deadline covering requests, response parsing, retries, and backoff. Abort the active request when the deadline expires, reject late completions, and clear timers when polling finishes. Retain the URL encoding fixes for both recording-detection lookup methods.

Merged current main, including the release-test cleanup fix.

Validation:

  • All 37 recordings API tests passed, including fake-clock coverage for pending responses, stalled responses, actual fetch timeouts/retries, late completions, recovery, and reserved characters in stream names.
  • Web and test TypeScript checks passed (npm run typecheck).
  • git diff --check passed.

matteius and others added 3 commits November 7, 2026 17:52
…API.tsx from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…API.tsx from Copilot Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@matteius matteius changed the title Potential fixes for 2 code quality findings Bound batch deletion polling and encode detection stream paths Nov 7, 2026
@matteius
matteius marked this pull request as ready for review November 7, 2026 22:59
@matteius
matteius merged commit 44763ba into main Nov 7, 2026
4 of 12 checks passed
@matteius
matteius deleted the ai-findings-autofix/web-js-components-preact-recordings-recordingsAPI.tsx branch November 7, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant