Repository navigation
Propagate SOD linkage through lightnvr_lib - #927
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
matteius
changed the title
matteius
marked this pull request as ready for review
November 7, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOD symbols are referenced by objects in the static
lightnvr_lib, but its link interface did not declare SOD. Consumers therefore needed their own direct SOD linkage to avoid unresolved symbols whenENABLE_SOD=ON.Publish
sodthroughlightnvr_liband remove the redundant direct linkage from the main executable and the Layer 2/3 unit-test helpers. Existing detection tests now exercise the inherited dependency. The change remains conditional onENABLE_SOD.Merged current main, including the batch-delete cancellation fix responsible for the previous browser-contract failure.
Validation:
ENABLE_SOD=ON; builtlightnvr,test_detection_model_motion, andtest_detection_system_onvif.lightnvr_lib.ENABLE_SOD=OFF; verified the generated detection-test link command has no SOD dependency.git diff --checkpassed.